Issue 5967043: Remove UserKey class, move registry-related functions out of string_util.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5967043: Remove UserKey class, move registry-related functions out of string_util. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by thakis

Modified:
12 years, 1 month ago

Reviewers:
Roger Tawa, Roger Tawa (Google)

CC:
rlz-codereviews_googlegroups.com

Base URL:
https://rlz.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove UserKey class, move registry-related functions out of string_util. No intended functionality change, just moving code around. BUG=none TEST=none

Patch Set 1 #

Total comments: 1

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -74 lines)			Patch
M	lib/string_utils.h	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	lib/string_utils.cc	View	3 chunks	+1 line, -34 lines	0 comments	Download
M	win/lib/machine_deal.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	win/lib/rlz_value_store_registry.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	win/lib/user_key.h	View	1 chunk	+15 lines, -10 lines	0 comments	Download
M	win/lib/user_key.cc	View	2 chunks	+29 lines, -8 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

thakis

As discussed. I'll rename user_key to registry_util in an immediate follow-up.

12 years, 1 month ago (2012-03-30 00:27:44 UTC) #1

Roger Tawa (Google)

12 years, 1 month ago (2012-03-30 13:30:52 UTC) #2

lgtm, one comment below

https://codereview.appspot.com/5967043/diff/1/win/lib/user_key.cc
File win/lib/user_key.cc (right):

https://codereview.appspot.com/5967043/diff/1/win/lib/user_key.cc#newcode53
win/lib/user_key.cc:53: ASSERT_STRING("Could not open HKEY_CURRENT_USER");
What's the point of this if and the variable key?  I think with all the
refactoring of this code, its no longer needed.

Expand All Messages | Collapse All Messages