Issue 5956051: code review 5956051: net/rpc: fix race condition when request write partiall...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5956051: code review 5956051: net/rpc: fix race condition when request write partiall... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by snaury

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, r, rsc

Visibility:
Public.

Description

net/rpc: fix race condition when request write partially fails When client fails to write a request is sends caller that error, however server might have failed to read that request in the mean time and replied with that error. When client then reads the response the call would no longer be pending, so call will be nil Handle this gracefully by discarding such server responses

Patch Set 1 #

Patch Set 2 : diff -r 98fc21971a1d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 98fc21971a1d https://go.googlecode.com/hg/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -13 lines)			Patch
	M	src/pkg/net/rpc/client.go	View	1	2 chunks	+20 lines, -13 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

snaury

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 11 months ago (2012-03-29 19:11:22 UTC) #1

snaury

On 2012/03/29 19:11:22, snaury wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...

12 years, 10 months ago (2012-05-17 21:28:28 UTC) #2

12 years, 9 months ago (2012-05-24 23:07:22 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=92d885d15380 ***

net/rpc: fix race condition when request write partially fails

When client fails to write a request is sends caller that error,
however server might have failed to read that request in the mean
time and replied with that error. When client then reads the
response the call would no longer be pending, so call will be nil

Handle this gracefully by discarding such server responses

R=golang-dev, r
CC=golang-dev, rsc
http://codereview.appspot.com/5956051

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages