Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(524)

Issue 5956050: Remove unused static functions from SampleApp and effects (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by DerekS
Modified:
12 years, 7 months ago
Reviewers:
epoger, reed1
CC:
skia-review_googlegroups.com, reed
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Remove unused static functions from SampleApp and effects Committed: https://code.google.com/p/skia/source/detail?r=3543

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -151 lines) Patch
M samplecode/SampleAll.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M samplecode/SampleText.cpp View 2 chunks +0 lines, -64 lines 0 comments Download
M samplecode/SampleTextEffects.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M src/effects/SkGradientShader.cpp View 2 chunks +0 lines, -42 lines 0 comments Download

Messages

Total messages: 5
DerekS
12 years, 7 months ago (2012-03-29 17:17:47 UTC) #1
DerekS
On 2012/03/29 17:17:47, djsollen wrote: The code analysis tool in my editor was catching these ...
12 years, 7 months ago (2012-03-29 17:18:57 UTC) #2
epoger
LGTM
12 years, 7 months ago (2012-03-29 17:34:43 UTC) #3
epoger
(CCed Mike just in case he knows that we want to keep that currently-unused code ...
12 years, 7 months ago (2012-03-29 17:35:16 UTC) #4
reed1
12 years, 7 months ago (2012-03-29 17:49:45 UTC) #5
kill kill kill
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b