Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2241)

Issue 59540043: Fix "RING ABOVE" key in the Finnish compose file. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by fujiwara
Modified:
10 years, 2 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com, fujiwara
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Fix "RING ABOVE" key in the Finnish compose file. Recently fi_FI compose table was updated in xorg/lib/libX11. http://cgit.freedesktop.org/xorg/lib/libX11/commit/?id=20fdccd8 http://cgit.freedesktop.org/xorg/lib/libX11/commit/?id=aacf95da BUG=rhbz#1060180

Patch Set 1 #

Patch Set 2 : Updated copyright. #

Total comments: 6

Patch Set 3 : Updated with message #2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -23 lines) Patch
M src/ibuscomposetable.h View 1 2 2 chunks +25 lines, -23 lines 0 comments Download

Messages

Total messages: 6
fujiwara
10 years, 2 months ago (2014-02-03 04:37:01 UTC) #1
Peng
lgtm with two nits. https://codereview.appspot.com/59540043/diff/20001/src/ibuscomposetable.h File src/ibuscomposetable.h (right): https://codereview.appspot.com/59540043/diff/20001/src/ibuscomposetable.h#newcode5 src/ibuscomposetable.h:5: * Copyright (C) 2014 Takao ...
10 years, 2 months ago (2014-02-03 15:46:46 UTC) #2
fujiwara
https://codereview.appspot.com/59540043/diff/20001/src/ibuscomposetable.h File src/ibuscomposetable.h (right): https://codereview.appspot.com/59540043/diff/20001/src/ibuscomposetable.h#newcode5 src/ibuscomposetable.h:5: * Copyright (C) 2014 Takao Fujiwara <takao.fujiwara1@gmail.com> On 2014/02/03 ...
10 years, 2 months ago (2014-02-04 02:31:35 UTC) #3
Peng
https://codereview.appspot.com/59540043/diff/20001/src/ibuscomposetable.h File src/ibuscomposetable.h (right): https://codereview.appspot.com/59540043/diff/20001/src/ibuscomposetable.h#newcode2009 src/ibuscomposetable.h:2009: 0, 0x00B4, /* U00B4 # ACUTE ACCENT */ On ...
10 years, 2 months ago (2014-02-04 03:32:41 UTC) #4
fujiwara
https://codereview.appspot.com/59540043/diff/20001/src/ibuscomposetable.h File src/ibuscomposetable.h (right): https://codereview.appspot.com/59540043/diff/20001/src/ibuscomposetable.h#newcode2009 src/ibuscomposetable.h:2009: 0, 0x00B4, /* U00B4 # ACUTE ACCENT */ On ...
10 years, 2 months ago (2014-02-04 03:36:09 UTC) #5
Peng
10 years, 2 months ago (2014-02-04 15:19:15 UTC) #6
Message was sent while issue was closed.
On 2014/02/04 03:36:09, fujiwara wrote:
> https://codereview.appspot.com/59540043/diff/20001/src/ibuscomposetable.h
> File src/ibuscomposetable.h (right):
> 
>
https://codereview.appspot.com/59540043/diff/20001/src/ibuscomposetable.h#new...
> src/ibuscomposetable.h:2009: 0, 0x00B4, /* U00B4  #  ACUTE ACCENT */
> On 2014/02/04 03:32:42, Peng wrote:
> > On 2014/02/04 02:31:45, fujiwara wrote:
> > > On 2014/02/03 15:46:46, Peng wrote:
> > > > Is it necessary to include U00B4 value in comment? I think the value
> > (0x00B4)
> > > is
> > > > already in the array. 
> > > 
> > > I think we don't modify the comments until all the comments have the
unified
> > > format.
> > > Currently el_GR/Compose file has the different format and maybe I think
it's
> a
> > > small bug in X11.
> > 
> > Don't understand your reply. I mean they unicode values are in the array
> > already. Don't think adding Uxxxx in comment are useful.
> > 
> 
> The comment is pulled from Compose file by program, src/gencomposetable, but
not
> by manual.

I see. thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b