Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(90)

Issue 5948043: Make Image::lock and unlock private and call them from Image::loadData. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by apatrick1
Modified:
12 years, 1 month ago
Reviewers:
dgkoch
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Make Image::lock and unlock private and call them from Image::loadData. This is because I want loadData to be able to decide whether to use LockRect/UnlockRect or UpdateSurface as the method to load the data, depending on whether the Images are backed by textures in the default pool or not. I think it actually cleans up the code a bit. Also, fixed a bug in subImageCompressed. The associated WebGL conformance test now passes. Committed: https://code.google.com/p/angleproject/source/detail?r=1013

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -154 lines) Patch
M src/libGLESv2/Texture.h View 3 chunks +28 lines, -28 lines 0 comments Download
M src/libGLESv2/Texture.cpp View 52 chunks +105 lines, -126 lines 1 comment Download

Messages

Total messages: 2
apatrick1
Hi Daniel, Another one for you. Note that this on trunk and surfaces are oriented ...
12 years, 1 month ago (2012-03-28 22:57:12 UTC) #1
dgkoch
12 years, 1 month ago (2012-03-31 02:59:56 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b