Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3201)

Issue 5941043: Consolidate PixelRef flattables with the standard impl (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by DerekS
Modified:
12 years, 3 months ago
Reviewers:
caryclark1, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Consolidate PixelRef flattables with the standard impl The flatten method on these functions can no longer be const as SkFlattenables declaration is not const and would result in the const methods only being called when the reference to the object was const. Committed: https://code.google.com/p/skia/source/detail?r=3533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -189 lines) Patch
M include/core/SkMallocPixelRef.h View 1 chunk +2 lines, -8 lines 0 comments Download
M include/core/SkPixelRef.h View 6 chunks +4 lines, -42 lines 0 comments Download
M include/gpu/SkGrTexturePixelRef.h View 2 chunks +4 lines, -0 lines 0 comments Download
M include/images/SkFlipPixelRef.h View 2 chunks +9 lines, -16 lines 0 comments Download
M include/images/SkImageRef.h View 1 chunk +1 line, -1 line 0 comments Download
M include/images/SkImageRef_GlobalPool.h View 1 chunk +1 line, -7 lines 0 comments Download
M src/core/SkBitmap.cpp View 2 chunks +6 lines, -13 lines 0 comments Download
M src/core/SkGraphics.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkMallocPixelRef.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkPixelRef.cpp View 3 chunks +4 lines, -67 lines 0 comments Download
M src/images/SkFlipPixelRef.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M src/images/SkImageRef.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/images/SkImageRef_GlobalPool.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M src/ports/SkGlobalInitialization_chromium.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 1 chunk +4 lines, -8 lines 0 comments Download
M src/ports/SkImageRef_ashmem.h View 1 chunk +2 lines, -6 lines 0 comments Download
M src/ports/SkImageRef_ashmem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
DerekS
gcl created a new issue when I updated my change. The original issue is http://codereview.appspot.com/5939053/
12 years, 3 months ago (2012-03-28 20:28:48 UTC) #1
caryclark1
12 years, 3 months ago (2012-03-28 20:41:04 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b