Fix a bunch of Coverity defects - class members not initialized in the constructor.

Fix a bunch of Coverity defects - class members not initialized in the constructor.

CID=14533,14036,9275,9271,4156,4153,4151,1666,1665,1618,1617,1616,1615

Committed: https://code.google.com/p/skia/source/detail?r=3532

[reed1, 2012-03-28 13:05:08]

https://codereview.appspot.com/5940049/diff/3001/src/core/SkCubicClipper.cpp
File src/core/SkCubicClipper.cpp (left):

https://codereview.appspot.com/5940049/diff/3001/src/core/SkCubicClipper.cpp#...
src/core/SkCubicClipper.cpp:13: SkCubicClipper::SkCubicClipper() {}
I think I prefer

{ fClip.setEmpty(); }

as calling MakeEmpty() naively will mean a memcpy of a temp 16 bytes, rather
than just a memset.

https://codereview.appspot.com/5940049/diff/3001/src/core/SkQuadClipper.cpp
File src/core/SkQuadClipper.cpp (left):

https://codereview.appspot.com/5940049/diff/3001/src/core/SkQuadClipper.cpp#o...
src/core/SkQuadClipper.cpp:25: SkQuadClipper::SkQuadClipper() {}
as with cubicclipper, prefer

fClip.setEmpty();

https://codereview.appspot.com/5940049/diff/3001/src/ports/SkFontHost_FreeTyp...
File src/ports/SkFontHost_FreeType.cpp (left):

https://codereview.appspot.com/5940049/diff/3001/src/ports/SkFontHost_FreeTyp...
src/ports/SkFontHost_FreeType.cpp:230: : fSkStream(strm), fFontID(fontID) {
If we need to init these in the constructor, lets set fRefCnt(1) instead of
zero, and then remove the assignment at the end of ref_ft_face().

[Steve VanDeBogart, 2012-03-28 16:48:29]

https://codereview.appspot.com/5940049/diff/3001/src/core/SkCubicClipper.cpp
File src/core/SkCubicClipper.cpp (left):

https://codereview.appspot.com/5940049/diff/3001/src/core/SkCubicClipper.cpp#...
src/core/SkCubicClipper.cpp:13: SkCubicClipper::SkCubicClipper() {}
On 2012/03/28 13:05:08, reed1 wrote:
> I think I prefer
> 
> { fClip.setEmpty(); }
> 
> as calling MakeEmpty() naively will mean a memcpy of a temp 16 bytes, rather
> than just a memset.

Done.

https://codereview.appspot.com/5940049/diff/3001/src/core/SkQuadClipper.cpp
File src/core/SkQuadClipper.cpp (left):

https://codereview.appspot.com/5940049/diff/3001/src/core/SkQuadClipper.cpp#o...
src/core/SkQuadClipper.cpp:25: SkQuadClipper::SkQuadClipper() {}
On 2012/03/28 13:05:08, reed1 wrote:
> as with cubicclipper, prefer
> 
> fClip.setEmpty();

Done.

https://codereview.appspot.com/5940049/diff/3001/src/ports/SkFontHost_FreeTyp...
File src/ports/SkFontHost_FreeType.cpp (left):

https://codereview.appspot.com/5940049/diff/3001/src/ports/SkFontHost_FreeTyp...
src/ports/SkFontHost_FreeType.cpp:230: : fSkStream(strm), fFontID(fontID) {
On 2012/03/28 13:05:08, reed1 wrote:
> If we need to init these in the constructor, lets set fRefCnt(1) instead of
> zero, and then remove the assignment at the end of ref_ft_face().

Done.

[bsalomon, 2012-03-28 17:10:11]

The GrGpu change LGTM

[reed1, 2012-03-28 18:46:47]

lgtm

Lets commit the FreeType changes as its own CL (no need for a 2nd review), since
its the only slightly tricky one (given the current mood around memory leaks).