Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(845)

Issue 5940045: disable GPU blur on small paths (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by bsalomon
Modified:
12 years, 8 months ago
Reviewers:
guanqun.lu, Stephen White, senorblanco, reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : increase blur radius range #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -9 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A samplecode/SampleAnimBlur.cpp View 1 1 chunk +70 lines, -0 lines 1 comment Download
M samplecode/SampleApp.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M samplecode/SampleCode.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 5 chunks +34 lines, -9 lines 1 comment Download

Messages

Total messages: 5
bsalomon
This is really a continuation of Guanqun's Issue at http://codereview.appspot.com/5726057/. Codereview only allows the Issue ...
12 years, 8 months ago (2012-03-27 20:15:20 UTC) #1
Stephen White
This might affect some fast/canvas layout test baselines, so we should probably give the skia ...
12 years, 8 months ago (2012-03-27 20:23:39 UTC) #2
Stephen White
And LGTM. :)
12 years, 8 months ago (2012-03-27 20:25:28 UTC) #3
guanqun
I haven't thought about this kind of animation to switch between cpu blur and gpu ...
12 years, 8 months ago (2012-03-28 08:15:23 UTC) #4
bsalomon
12 years, 8 months ago (2012-03-28 15:07:20 UTC) #5
Committed with Stephen's suggestions at r3514.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b