Issue 5935051: Fix Coverity reports. (Mostly use of uninitialised values.)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5935051: Fix Coverity reports. (Mostly use of uninitialised values.) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by Steve VanDeBogart

Modified:
12 years, 3 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix Coverity reports. (Mostly use of uninitialised values.) CID=537,103419,103631,103632,103633 Initial review: https://codereview.appspot.com/5936047/ Committed: https://code.google.com/p/skia/source/detail?r=3534

Patch Set 1 #

Total comments: 2

Patch Set 2 : Explicit initializers #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -8 lines)			Patch
M	src/gpu/GrAAConvexPathRenderer.cpp	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ports/SkOSFile_stdio.cpp	View		1 chunk	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Steve VanDeBogart

https://codereview.appspot.com/5935051/diff/1/src/gpu/GrAAConvexPathRenderer.cpp File src/gpu/GrAAConvexPathRenderer.cpp (right): https://codereview.appspot.com/5935051/diff/1/src/gpu/GrAAConvexPathRenderer.cpp#newcode58 src/gpu/GrAAConvexPathRenderer.cpp:58: SkPoint p0 = {}; Initializing things this way leads ...

12 years, 3 months ago (2012-03-28 17:58:27 UTC) #1

bsalomon

12 years, 3 months ago (2012-03-28 18:10:05 UTC) #2

On 2012/03/28 17:58:27, Steve VanDeBogart wrote:
>
https://codereview.appspot.com/5935051/diff/1/src/gpu/GrAAConvexPathRenderer.cpp
> File src/gpu/GrAAConvexPathRenderer.cpp (right):
> 
>
https://codereview.appspot.com/5935051/diff/1/src/gpu/GrAAConvexPathRenderer....
> src/gpu/GrAAConvexPathRenderer.cpp:58: SkPoint p0 = {};
> Initializing things this way leads to compiler warnings:
> 
> 
> ../src/gpu/GrAAConvexPathRenderer.cpp:56: warning: missing initializer for
> member ‘SkPoint::fX’
> ../src/gpu/GrAAConvexPathRenderer.cpp:56: warning: missing initializer for
> member ‘SkPoint::fY’
> 
> Changed to the "= {0, 0};" style
> 
>
https://codereview.appspot.com/5935051/diff/1/src/ports/SkFontHost_FreeType.cpp
> File src/ports/SkFontHost_FreeType.cpp (right):
> 
>
https://codereview.appspot.com/5935051/diff/1/src/ports/SkFontHost_FreeType.c...
> src/ports/SkFontHost_FreeType.cpp:1119: FT_BBox bbox = {};  // Suppress
Coverity
> warning.
> Here too.

LGTM

Expand All Messages | Collapse All Messages