Add the osml feature

The osml feature signals TemplateRewriter to only process OSML tags, a strict subset of OpenSocial Templating. This is defined by section 3 of the OpenSocial Markup Language Tags Specification v0.9

Spec: http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/OpenSocial-Markup-Language-Tags.html#rfc.section.3

[johnfargo, 2010-03-17 18:14:17]

Hi Chirag:

Looks like the base URL you set for this CL still includes "incubator" --
could you remove that and confirm when done?

Thanks,
John

On Wed, Mar 17, 2010 at 8:53 AM, <chiragshah1@gmail.com> wrote:

> Reviewers: shindig.remailer_gmail.com,
>
> Description:
>  The osml feature signals TemplateRewriter to only process OSML tags, a
> strict subset of OpenSocial Templating. This is defined by section 3 of
> the OpenSocial Markup Language Tags Specification v0.9
>
> Spec:
>
>
http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/OpenSocial-...
>
> Please review this at http://codereview.appspot.com/593044/show
>
> Affected files:
>  features/src/main/javascript/features/features.txt
>  features/src/main/javascript/features/osml/feature.xml
>
> 
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java
>
> 
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/TemplateRewriterTest.java
>
>
>

[henry.saputra, 2010-03-17 18:24:41]

HI John,

I think its because the url for repository in the codereview still points to
incubator.

I can add a new branch for the new shindig trunk repository url but its
better to change the existing "real trunk" and "trunk" repository.

Since I didnt created the shindig trunk repositories I cant modified them.

- Henry

On Wed, Mar 17, 2010 at 11:14 AM, John Hjelmstad <johnfargo@gmail.com>wrote:

> Hi Chirag:
>
> Looks like the base URL you set for this CL still includes "incubator" --
> could you remove that and confirm when done?
>
> Thanks,
> John
>
> On Wed, Mar 17, 2010 at 8:53 AM, <chiragshah1@gmail.com> wrote:
>
> > Reviewers: shindig.remailer_gmail.com,
> >
> > Description:
> >  The osml feature signals TemplateRewriter to only process OSML tags, a
> > strict subset of OpenSocial Templating. This is defined by section 3 of
> > the OpenSocial Markup Language Tags Specification v0.9
> >
> > Spec:
> >
> >
>
http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/OpenSocial-...
> >
> > Please review this at http://codereview.appspot.com/593044/show
> >
> > Affected files:
> >  features/src/main/javascript/features/features.txt
> >  features/src/main/javascript/features/osml/feature.xml
> >
> >
> 
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java
> >
> >
> 
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/TemplateRewriterTest.java
> >
> >
> >
>

[johnfargo, 2010-03-17 18:29:59]

Odd, I use "Shindig - *trunk* - Real Trunk" and be sure to specify Base: "
http://svn.apache.org/repos/asf/shindig/trunk/" when creating new entries,
which seems to work fine for me. I use the web UI rather than upload.py

On Wed, Mar 17, 2010 at 11:24 AM, Henry Saputra <henry.saputra@gmail.com>wrote:

> HI John,
>
> I think its because the url for repository in the codereview still points
> to incubator.
>
> I can add a new branch for the new shindig trunk repository url but its
> better to change the existing "real trunk" and "trunk" repository.
>
> Since I didnt created the shindig trunk repositories I cant modified them.
>
> - Henry
>
>
> On Wed, Mar 17, 2010 at 11:14 AM, John Hjelmstad <johnfargo@gmail.com>wrote:
>
>> Hi Chirag:
>>
>> Looks like the base URL you set for this CL still includes "incubator" --
>> could you remove that and confirm when done?
>>
>> Thanks,
>> John
>>
>> On Wed, Mar 17, 2010 at 8:53 AM, <chiragshah1@gmail.com> wrote:
>>
>> > Reviewers: shindig.remailer_gmail.com,
>> >
>> > Description:
>> >  The osml feature signals TemplateRewriter to only process OSML tags, a
>> > strict subset of OpenSocial Templating. This is defined by section 3 of
>> > the OpenSocial Markup Language Tags Specification v0.9
>> >
>> > Spec:
>> >
>> >
>>
http://www.opensocial.org/Technical-Resources/opensocial-spec-v09/OpenSocial-...
>> >
>> > Please review this at http://codereview.appspot.com/593044/show
>> >
>> > Affected files:
>> >  features/src/main/javascript/features/features.txt
>> >  features/src/main/javascript/features/osml/feature.xml
>> >
>> >
>> 
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java
>> >
>> >
>> 
java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/TemplateRewriterTest.java
>> >
>> >
>> >
>>
>
>

[chirag, 2010-03-17 18:53:26]

Switched to "Correct Trunk"

[johnfargo, 2010-03-17 20:13:57]

http://codereview.appspot.com/593044/diff/1/3
File features/src/main/javascript/features/features.txt (right):

http://codereview.appspot.com/593044/diff/1/3#newcode54
features/src/main/javascript/features/features.txt:54: features/osml/feature.xml
nit: out of order

http://codereview.appspot.com/593044/diff/1/5
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java
(right):

http://codereview.appspot.com/593044/diff/1/5#newcode113
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java:113:
Map<String, Feature> directFeatures = gadget.getSpec().getModulePrefs()
why only direct?

http://codereview.appspot.com/593044/diff/1/5#newcode117
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java:117:
if (f == null && directFeatures.containsKey("osml")) {
define "osml" as a public static final String

[chirag, 2010-03-18 04:46:21]

http://codereview.appspot.com/593044/diff/1/3
File features/src/main/javascript/features/features.txt (right):

http://codereview.appspot.com/593044/diff/1/3#newcode54
features/src/main/javascript/features/features.txt:54: features/osml/feature.xml
On 2010/03/17 20:13:57, johnfargo wrote:
> nit: out of order

Done.

http://codereview.appspot.com/593044/diff/1/5
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java
(right):

http://codereview.appspot.com/593044/diff/1/5#newcode113
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java:113:
Map<String, Feature> directFeatures = gadget.getSpec().getModulePrefs()
Mainly because it was done like that before.

I originally tried to make it pick up opensocial-templates as a transitive
dependency (via gadget.getAllFeatures), but couldn't figure out a way to get the
<String, Feature> map without losing parameters if it was a direct feature.

For Example:
I wanted to preserve the client parameter in a gadget with "<Require
feature='opensocial-templates'><Param name='client'>param</Param></Require>".



On 2010/03/17 20:13:57, johnfargo wrote:
> why only direct?

http://codereview.appspot.com/593044/diff/1/5#newcode117
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java:117:
if (f == null && directFeatures.containsKey("osml")) {
On 2010/03/17 20:13:57, johnfargo wrote:
> define "osml" as a public static final String

Done.

[chirag, 2010-03-18 04:48:01]

Fixed issues discovered by John

[chirag, 2010-03-18 04:54:09]

More fixes

[johnfargo, 2010-03-19 01:15:39]

LGTM