Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16419)

Issue 59240044: combined lr-wpan patch from Margherita and Sascha

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by Tom Henderson
Modified:
10 years, 1 month ago
Reviewers:
Tommaso Pecorella
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

This patch was posted to ns-developers on January 23: http://mailman.isi.edu/pipermail/ns-developers/2014-January/011692.html The main features implemented by the first patch are: * Support for ACKs * Only a single packet can be received at once. The first packet with a signal power higher than the receiver sensitivity is completely received, while packets arriving during reception of a packet are always dropped. No interference modelling. * Fixed bug https://www.nsnam.org/bugzilla/show_bug.cgi?id=1775 * Switching the transceiver state takes aTurnaround time * 6LoWPAN support in NetDevice * Removed some bugs in the PHY and MAC The main features of the second patch are the version 1 patch sent by Sascha on 23.01.2014 plus (Sascha's comments below pasted in): + Fixes for compiler errors in tests and examples. - I didn't test the examples. - There are no current tests for the new code. + clang and icpc fixes. + Many code cleanups. - Mostly removing unnecessary includes. - Removal of unused source files. + Bug fix for the MAC "state machine" in conjunction with pending ACKs. - If a regular packet is received while waiting for an ACK, the ACK is considered as lost. + Feature patch of Erwan Livolant for FCS calculation - I changed the patch slightly to enable FCS calculation and verification only when the global attribute ChecksumEnable is set, like it is done in the csma module.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Sascha's v2 patch 2-18-04 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1538 lines, -635 lines) Patch
M src/lr-wpan/examples/lr-wpan-data.cc View 1 3 chunks +20 lines, -13 lines 0 comments Download
M src/lr-wpan/examples/lr-wpan-error-distance-plot.cc View 1 1 chunk +20 lines, -22 lines 0 comments Download
M src/lr-wpan/examples/lr-wpan-error-model-plot.cc View 1 1 chunk +9 lines, -9 lines 0 comments Download
M src/lr-wpan/examples/lr-wpan-packet-print.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/lr-wpan/examples/lr-wpan-phy-test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/lr-wpan/helper/lr-wpan-helper.h View 1 2 chunks +8 lines, -9 lines 0 comments Download
M src/lr-wpan/helper/lr-wpan-helper.cc View 1 1 chunk +7 lines, -6 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-csmaca.h View 1 6 chunks +24 lines, -20 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-csmaca.cc View 1 10 chunks +68 lines, -53 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-error-model.h View 1 3 chunks +4 lines, -6 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-error-model.cc View 1 4 chunks +23 lines, -23 lines 0 comments Download
A src/lr-wpan/model/lr-wpan-lqi-tag.h View 1 1 chunk +69 lines, -0 lines 0 comments Download
A src/lr-wpan/model/lr-wpan-lqi-tag.cc View 1 1 chunk +94 lines, -0 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-mac.h View 1 9 chunks +61 lines, -27 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-mac.cc View 1 17 chunks +499 lines, -166 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-mac-header.h View 1 3 chunks +7 lines, -9 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-mac-header.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-mac-trailer.h View 1 3 chunks +20 lines, -7 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-mac-trailer.cc View 1 2 chunks +94 lines, -18 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-net-device.h View 1 4 chunks +14 lines, -10 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-net-device.cc View 1 9 chunks +95 lines, -28 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-phy.h View 1 8 chunks +24 lines, -24 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-phy.cc View 1 30 chunks +307 lines, -113 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-spectrum-signal-parameters.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-spectrum-signal-parameters.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-spectrum-value-helper.h View 1 3 chunks +6 lines, -5 lines 0 comments Download
M src/lr-wpan/model/lr-wpan-spectrum-value-helper.cc View 1 5 chunks +29 lines, -28 lines 0 comments Download
M src/lr-wpan/test/lr-wpan-error-model-test.cc View 1 2 chunks +15 lines, -16 lines 0 comments Download
M src/lr-wpan/test/lr-wpan-packet-test.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/lr-wpan/test/lr-wpan-pd-plme-sap-test.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/lr-wpan/test/lr-wpan-spectrum-value-helper-test.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/lr-wpan/wscript View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Tommaso Pecorella
10 years, 2 months ago (2014-02-11 19:33:33 UTC) #1
https://codereview.appspot.com/59240044/diff/1/src/lr-wpan/helper/lr-wpan-hel...
File src/lr-wpan/helper/lr-wpan-helper.cc (right):

https://codereview.appspot.com/59240044/diff/1/src/lr-wpan/helper/lr-wpan-hel...
src/lr-wpan/helper/lr-wpan-helper.cc:26: #include <ns3/mobility-model.h>
I don't think this is necessary.

https://codereview.appspot.com/59240044/diff/1/src/lr-wpan/model/lr-wpan-mac-...
File src/lr-wpan/model/lr-wpan-mac-header.h (right):

https://codereview.appspot.com/59240044/diff/1/src/lr-wpan/model/lr-wpan-mac-...
src/lr-wpan/model/lr-wpan-mac-header.h:45: #include <ns3/mac64-address.h>
These are "", as they're not system-wide.

Also, check the includes in the other files as well.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b