Build libjpeg from source for all platforms
(We were already doing so on Mac and Windows.)
Committed: https://code.google.com/p/skia/source/detail?r=3497
On 2012/03/26 19:22:46, robertphillips wrote: > LGTM - let's give it a try. Hi, this ...
12 years, 8 months ago
(2012-03-27 07:21:20 UTC)
#5
On 2012/03/26 19:22:46, robertphillips wrote:
> LGTM - let's give it a try.
Hi, this CL broke my linux build. I checked out skia alone, so there's no
libjpeg source code around...
Thanks!
--guanqun
On 2012/03/27 07:21:20, guanqun wrote: > On 2012/03/26 19:22:46, robertphillips wrote: > > LGTM - ...
12 years, 8 months ago
(2012-03-27 10:23:20 UTC)
#6
On 2012/03/27 07:21:20, guanqun wrote:
> On 2012/03/26 19:22:46, robertphillips wrote:
> > LGTM - let's give it a try.
>
> Hi, this CL broke my linux build. I checked out skia alone, so there's no
> libjpeg source code around...
>
> Thanks!
> --guanqun
Guanqun- We added an external dependency on libjpeg in
http://code.google.com/p/skia/source/detail?r=3334. When you synced your client
past that revision, did nothing appear in third_party/externals/libjpeg ?
On 2012/03/27 10:23:20, epoger wrote: > On 2012/03/27 07:21:20, guanqun wrote: > > On 2012/03/26 ...
12 years, 8 months ago
(2012-03-27 10:25:07 UTC)
#7
On 2012/03/27 10:23:20, epoger wrote:
> On 2012/03/27 07:21:20, guanqun wrote:
> > On 2012/03/26 19:22:46, robertphillips wrote:
> > > LGTM - let's give it a try.
> >
> > Hi, this CL broke my linux build. I checked out skia alone, so there's no
> > libjpeg source code around...
> >
> > Thanks!
> > --guanqun
>
> Guanqun- We added an external dependency on libjpeg in
> http://code.google.com/p/skia/source/detail?r=3334. When you synced your
client
> past that revision, did nothing appear in third_party/externals/libjpeg ?
(In other words, the libjpeg source should have been added to your Skia tree
automatically for you...)
Ah, I figured why, because I'm not using svn directly, I'm using git svn. So ...
12 years, 8 months ago
(2012-03-28 01:16:18 UTC)
#8
Ah, I figured why, because I'm not using svn directly, I'm using git svn. So git
svn doesn't help me pull these externals automatically... After checkout the
libjpeg under external directory, the compilation is OK now, sorry for the false
alarm.
Issue 5909067: Build libjpeg from source for all platforms
(Closed)
Created 12 years, 8 months ago by epoger
Modified 12 years, 8 months ago
Reviewers: robertphillips, guanqun
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0