code review 5909045: doc: Change id of footer

doc: Change id of footer

The heading "Copyright" uses id="copyright" as the anchor name.
However, there is also a <div id="copyright"> at the bottom.
Using the same ID value twice in the same file is illegal
(http://www.w3.org/TR/html401/struct/links.html#h-12.2.3).

[bsiegert, 2012-03-24 11:26:00]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-03-24 16:30:58]

I'd rather change the page footer's copyright id.

We've often linked to /doc/contribute.html#copyright when telling people to
fill out the CLA.

The footer's ID, on the other hand, exists purely for CSS I believe.  At
least nobody ever links to it.


On Sat, Mar 24, 2012 at 4:26 AM, <bsiegert@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> doc: Change ambiguous id in contribute.html
>
> The heading "Copyright" uses id="copyright" as the anchor name.
> However, there is also a <div id="copyright"> at the bottom.
> Using the same ID value twice in the same file is illegal
>
(http://www.w3.org/TR/html401/**struct/links.html#h-12.2.3<http://www.w3.org/T...
> ).
>
> Please review this at
http://codereview.appspot.com/**5909045/<http://codereview.appspot.com/5909045/>
>
> Affected files:
>  M doc/contribute.html
>
>
> Index: doc/contribute.html
> ==============================**==============================**=======
> --- a/doc/contribute.html
> +++ b/doc/contribute.html
> @@ -95,7 +95,7 @@
>  it checks that Go code being checked in is formatted in the standard
> style,
>  as defined by <a href="/cmd/gofmt">gofmt</a>,
>  and it checks that the author of the code is properly recorded for
> -<a href="#copyright">copyright purposes</a>.
> +<a href="#go_copyright">copyright purposes</a>.
>  </p>
>
>  <p>
> @@ -486,7 +486,7 @@
>  </p>
>
>
> -<h3 id="copyright">Copyright</h3>
> +<h3 id="go_copyright">Copyright</**h3>
>
>  <p>Files in the Go repository don't list author names,
>  both to avoid clutter and to avoid having to keep the lists up to date.
>
>
>

[bsiegert, 2012-03-24 20:03:30]

Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-03-26 13:15:52]

LGTM.  Leaving for Brad/Robert.

[bradfitz, 2012-03-26 16:12:00]

LGTM

On Sat, Mar 24, 2012 at 1:03 PM, <bsiegert@gmail.com> wrote:

> Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
> golang-dev@googlegroups.com),
>
> Please take another look.
>
>
> http://codereview.appspot.com/**5909045/
>

[bradfitz, 2012-03-26 16:13:45]

*** Submitted as http://code.google.com/p/go/source/detail?r=556341822a38 ***

doc: Change id of footer

The heading "Copyright" uses id="copyright" as the anchor name.
However, there is also a <div id="copyright"> at the bottom.
Using the same ID value twice in the same file is illegal
(http://www.w3.org/TR/html401/struct/links.html#h-12.2.3).

R=golang-dev, bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/5909045

Committer: Brad Fitzpatrick <bradfitz@golang.org>