Issue 5907059: Tweaks to make the use of chrome's net stack forceable through gyp.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5907059: Tweaks to make the use of chrome's net stack forceable through gyp. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 12 months ago by thakis

Modified:
10 years, 12 months ago

Reviewers:
Roger Tawa, Roger Tawa (Google)

CC:
rlz-codereviews_googlegroups.com

Base URL:
https://rlz.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Tweaks to make the use of chrome's net stack forceable through gyp. Also whitelist usage of "net" and (for now) "content" for check_deps BUG=none TEST=none TBR=rogerta

Patch Set 1 #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	DEPS	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	rlz.gyp	View		1 chunk	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

thakis

Minor things that the tryjob for my chromium CL complained about.

10 years, 12 months ago (2012-03-25 20:45:21 UTC) #1

lgtm

Expand All Messages | Collapse All Messages