Issue 5905059: Fix for truncated CustomDataMasks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5905059: Fix for truncated CustomDataMasks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by nicholasbishop

Modified:
13 years ago

Reviewers:
brechtvl, bf-codereview

Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/

Visibility:
Public.

Description

Relevant bug report: http://projects.blender.org/tracker/index.php?func=detail&aid=30680&group_id=9&atid=498 Basically just added a new link type with correct payload size/type.

Patch Set 1 #

Created: 13 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+34 lines, -26 lines)			Patch
source/blender/blenkernel/BKE_modifier.h	View	1 chunk	+10 lines, -5 lines	0 comments	Download
source/blender/blenkernel/intern/DerivedMesh.c	View	9 chunks	+9 lines, -9 lines	0 comments	Download
source/blender/blenkernel/intern/modifier.c	View	2 chunks	+15 lines, -12 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nicholasbishop

13 years ago (2012-03-26 16:26:14 UTC) #3

On 2012/03/26 10:46:43, brechtvl wrote:
> LGTM.

Thanks for reviewing, committed to r45186.

Expand All Messages | Collapse All Messages