OST Client: Library loading and other fixes

- Bugs fixed in data context handling
- Support for required library declaration via "requireLibrary" param
  - Template processing deferred until required libraries are loaded
- Correct timing of feature param processing
- Minor Loader refactoring in preparation for library injection
- Namespace declarations on template container tags honored

JIRA issue: https://issues.apache.org/jira/browse/SHINDIG-1046

[etnu00, 2009-05-05 22:21:01]

http://codereview.appspot.com/59046/diff/1/5
File
features/src/main/javascript/features/opensocial-data-context/datacontext.js
(right):

http://codereview.appspot.com/59046/diff/1/5#newcode167
Line 167: for (key in dataSets) {
"key" here creates a new global, which will probably yield unexpected bugs later
(always use var when declaring variables).

http://codereview.appspot.com/59046/diff/1/3
File features/src/main/javascript/features/opensocial-templates/base.js (right):

http://codereview.appspot.com/59046/diff/1/3#newcode132
Line 132: * @return {opensocial.tempalte.Template} A compiled Template object.
typo

http://codereview.appspot.com/59046/diff/1/2
File features/src/main/javascript/features/opensocial-templates/loader.js
(right):

http://codereview.appspot.com/59046/diff/1/2#newcode94
Line 94: os.Loader.loadContent(req.responseText, url);
I'd recommend replacing all of this with gadgets.io.makeNonProxiedRequest.

http://codereview.appspot.com/59046/diff/1/6
File features/src/main/javascript/features/xmlutil/xmlutil.js (right):

http://codereview.appspot.com/59046/diff/1/6#newcode112
Line 112: if (name.length < 7 || name.substring(0, 6) != 'xmlns:') {
The length check isn't needed here. String.substring will always terminate at
the last character.

http://codereview.appspot.com/59046/diff/1/6#newcode115
Line 115: namespaces[name.substring(6, name.length)] = el.getAttribute(name);
You should probably not be calling substring twice in a loop like this.

[levik, 2009-05-05 23:30:47]

http://codereview.appspot.com/59046/diff/1/5
File
features/src/main/javascript/features/opensocial-data-context/datacontext.js
(right):

http://codereview.appspot.com/59046/diff/1/5#newcode167
Line 167: for (key in dataSets) {
On 2009/05/05 22:21:02, etnu00 wrote:
> "key" here creates a new global, which will probably yield unexpected bugs
later
> (always use var when declaring variables).

Fixed

http://codereview.appspot.com/59046/diff/1/3
File features/src/main/javascript/features/opensocial-templates/base.js (right):

http://codereview.appspot.com/59046/diff/1/3#newcode132
Line 132: * @return {opensocial.tempalte.Template} A compiled Template object.
On 2009/05/05 22:21:02, etnu00 wrote:
> typo

Fixed

http://codereview.appspot.com/59046/diff/1/2
File features/src/main/javascript/features/opensocial-templates/loader.js
(right):

http://codereview.appspot.com/59046/diff/1/2#newcode94
Line 94: os.Loader.loadContent(req.responseText, url);
On 2009/05/05 22:21:02, etnu00 wrote:
> I'd recommend replacing all of this with gadgets.io.makeNonProxiedRequest.

This logic is present here for when gadgets are not available - one of the goals
of OST is to be easily usable as a standalone template library.

http://codereview.appspot.com/59046/diff/1/6
File features/src/main/javascript/features/xmlutil/xmlutil.js (right):

http://codereview.appspot.com/59046/diff/1/6#newcode112
Line 112: if (name.length < 7 || name.substring(0, 6) != 'xmlns:') {
On 2009/05/05 22:21:02, etnu00 wrote:
> The length check isn't needed here. String.substring will always terminate at
> the last character.

Fixed

http://codereview.appspot.com/59046/diff/1/6#newcode115
Line 115: namespaces[name.substring(6, name.length)] = el.getAttribute(name);
On 2009/05/05 22:21:02, etnu00 wrote:
> You should probably not be calling substring twice in a loop like this.

I'm using different portions of the string. Is there a better way? I don't think
performance is an issue here, because there will generally be very few NS
declarations on these tags. (usually 1, 2-3 max)

[etnu00, 2009-05-06 02:20:14]

looks good.

http://codereview.appspot.com/59046/diff/1/6
File features/src/main/javascript/features/xmlutil/xmlutil.js (right):

http://codereview.appspot.com/59046/diff/1/6#newcode115
Line 115: namespaces[name.substring(6, name.length)] = el.getAttribute(name);
On 2009/05/05 23:30:47, levik wrote:
> On 2009/05/05 22:21:02, etnu00 wrote:
> > You should probably not be calling substring twice in a loop like this.
> 
> I'm using different portions of the string. Is there a better way? I don't
think
> performance is an issue here, because there will generally be very few NS
> declarations on these tags. (usually 1, 2-3 max)

Sorry, I misread that.