Issue 5902058: code review 5902058: cmd/go: explain versions better

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5902058: code review 5902058: cmd/go: explain versions better (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by r

Modified:
12 years, 11 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

cmd/go: explain versions better Summarize the desiderata for selecting versions of remote packages to get. Fixes issue 3394.

Patch Set 2 : diff -r 0b3b5914a3c2 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r f5de9f65682b https://code.google.com/p/go/ #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -2 lines)			Patch
	M	src/cmd/go/doc.go	View	1 2	1 chunk	+9 lines, -1 line	0 comments	Download
	M	src/cmd/go/get.go	View	1 2	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years, 11 months ago (2012-03-26 05:56:57 UTC) #1

adg

http://codereview.appspot.com/5902058/diff/1/src/cmd/go/get.go File src/cmd/go/get.go (right): http://codereview.appspot.com/5902058/diff/1/src/cmd/go/get.go#newcode41 src/cmd/go/get.go:41: is "weekly.YYYY-MM-DD", it searches for a package version labeled ...

12 years, 11 months ago (2012-03-26 06:33:03 UTC) #2

Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 11 months ago (2012-03-26 06:35:58 UTC) #3

adg

LGTM http://codereview.appspot.com/5902058/diff/3002/src/cmd/go/get.go File src/cmd/go/get.go (right): http://codereview.appspot.com/5902058/diff/3002/src/cmd/go/get.go#newcode42 src/cmd/go/get.go:42: installation using release "weekly.YYYY-MM-DD", it searches for a ...

12 years, 11 months ago (2012-03-26 06:40:44 UTC) #4

12 years, 11 months ago (2012-03-26 06:47:43 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=20f2f8a2de10 ***

cmd/go: explain versions better
Summarize the desiderata for selecting versions of remote packages to get.
Fixes issue 3394.

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/5902058

Expand All Messages | Collapse All Messages