code review 5900049: doc/reference-cmd: use vet as example, not fmt

doc/reference-cmd: use vet as example, not fmt
"go tool fmt" doesn't work, "go tool vet" does.

[r, 2012-03-24 10:45:24]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[rog, 2012-03-24 13:16:44]

FWIW I think "go vet program.go" should work fine too, although I haven't
tried it.
On 24 Mar 2012 10:45, <r@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> doc/reference-cmd: use vet as example, not fmt
> "go tool fmt" doesn't work, "go tool vet" does.
>
> Please review this at
http://codereview.appspot.com/**5900049/<http://codereview.appspot.com/5900049/>
>
> Affected files:
>  M doc/reference-cmd.html
>
>
> Index: doc/reference-cmd.html
> ==============================**==============================**=======
> --- a/doc/reference-cmd.html
> +++ b/doc/reference-cmd.html
> @@ -19,10 +19,10 @@
>
>  <p>
>  The programs can also be run as stand-alone binaries, with unmodified
> arguments,
> -using the go tool subcommand, such as "go tool fmt".
> +using the go tool subcommand, such as "go tool vet".
>  This style of invocation allows, for instance, reformatting a single
> source file rather than
> -an entire package: "go tool fmt myprogram.go" as compared to
> -"go fmt mypackage".
> +an entire package: "go tool vet myprogram.go" as compared to
> +"go vet mypackage".
>  Some of the commands, such as prof and yacc, are accessible
>  only through the go tool subcommand.
>  </p>
>
>
>

[r2, 2012-03-24 13:28:51]

On 25/03/2012, at 12:16 AM, roger peppe wrote:

> FWIW I think "go vet program.go" should work fine too, although I haven't
tried it.
> 

it does, but that just complicates the presentation further and needlessly
contradicts the point i'm making. this is an introduction, not a manual.

-rob

[minux1, 2012-03-24 14:34:20]

http://codereview.appspot.com/5900049/diff/1/doc/reference-cmd.html
File doc/reference-cmd.html (right):

http://codereview.appspot.com/5900049/diff/1/doc/reference-cmd.html#newcode23
doc/reference-cmd.html:23: This style of invocation allows, for instance,
reformatting a single source file rather than
reformatting? should all the fmt change to vet?

[r, 2012-03-24 21:14:49]

Hello golang-dev@googlegroups.com, rogpeppe@gmail.com, r@google.com,
minux.ma@gmail.com (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-03-24 23:27:07]

LGTM

On Sat, Mar 24, 2012 at 2:14 PM, <r@golang.org> wrote:

> Hello golang-dev@googlegroups.com, rogpeppe@gmail.com, r@google.com,
> minux.ma@gmail.com (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
http://codereview.appspot.com/**5900049/<http://codereview.appspot.com/5900049/>
>

[r, 2012-03-25 00:35:21]

*** Submitted as http://code.google.com/p/go/source/detail?r=ee5c7588cb7f ***

doc/reference-cmd: use vet as example, not fmt
"go tool fmt" doesn't work, "go tool vet" does.

R=golang-dev, rogpeppe, r, minux.ma, bradfitz
CC=golang-dev
http://codereview.appspot.com/5900049

[rog, 2012-03-25 17:22:38]

On 24 March 2012 13:28, Rob 'Commander' Pike <r@google.com> wrote:
>
> On 25/03/2012, at 12:16 AM, roger peppe wrote:
>
> FWIW I think "go vet program.go" should work fine too, although I haven't
> tried it.
>
> it does, but that just complicates the presentation further and needlessly
> contradicts the point i'm making. this is an introduction, not a manual.

sorry, i didn't intend to be needlessly contradictory.

i thought that it might be possible to use a useful example,
rather than one which is easily accomplished in the standard
way.

for example, "go tool" makes it possible to use flags that aren't possible
through the go command - -printfuncs being one.