Issue 58930044: Install pygtk2 libraries to python2 site-packages.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 58930044: Install pygtk2 libraries to python2 site-packages. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by fujiwara

Modified:
10 years, 2 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Install pygtk2 libraries to python2 site-packages.

Patch Set 2 : Updated with message #2. #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -14 lines)			Patch
M	bindings/pygobject/Makefile.am	View	1	3 chunks	+12 lines, -1 line	0 comments	Download
M	configure.ac	View	1	5 chunks	+16 lines, -7 lines	0 comments	Download
M	ibus/Makefile.am	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download
M	ibus/interface/Makefile.am	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/58930044/diff/1/bindings/pygobject/Makefile.am File bindings/pygobject/Makefile.am (right): https://codereview.appspot.com/58930044/diff/1/bindings/pygobject/Makefile.am#newcode25 bindings/pygobject/Makefile.am:25: am__py2_compile = PYTHON=$(PYTHON2) $(SHELL) $(py_compile) How about py2_compile?

10 years, 2 months ago (2014-01-31 13:11:48 UTC) #2

fujiwara

10 years, 2 months ago (2014-02-03 02:28:06 UTC) #3

Peng

10 years, 2 months ago (2014-02-03 03:51:14 UTC) #4

On 2014/02/03 02:28:06, fujiwara wrote:
> https://codereview.appspot.com/58930044/diff/1/bindings/pygobject/Makefile.am
> File bindings/pygobject/Makefile.am (right):
> 
>
https://codereview.appspot.com/58930044/diff/1/bindings/pygobject/Makefile.am...
> bindings/pygobject/Makefile.am:25: am__py2_compile = PYTHON=$(PYTHON2)
$(SHELL)
> $(py_compile)
> On 2014/01/31 13:11:48, Peng wrote:
> > How about py2_compile? 
> 
> Done.

lgtm

Expand All Messages | Collapse All Messages