Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(354)

Issue 5890043: Cleanup Macros arround static initializers for SkFlattenable. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by DerekS
Modified:
12 years, 8 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Cleanup Macros arround static initializers for SkFlattenable. This CL also removes an unused debugging function from the class

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -180 lines) Patch
M experimental/Debugger/SkDebugDumper.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M gm/gmmain.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M gyp/effects.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M include/core/SkColorFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkColorShader.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M include/core/SkEmptyShader.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M include/core/SkFlattenable.h View 1 2 2 chunks +13 lines, -23 lines 0 comments Download
M include/core/SkPathEffect.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkShape.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkXfermode.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/Sk1DPathEffect.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/effects/Sk2DPathEffect.h View 2 chunks +0 lines, -4 lines 0 comments Download
M include/effects/SkAvoidXfermode.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/effects/SkBlurDrawLooper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/effects/SkBlurImageFilter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/effects/SkBlurMaskFilter.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/effects/SkColorMatrixFilter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/effects/SkCornerPathEffect.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/effects/SkDashPathEffect.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/effects/SkDiscretePathEffect.h View 1 chunk +0 lines, -2 lines 0 comments Download
D include/effects/SkEffects.h View 1 1 chunk +0 lines, -16 lines 0 comments Download
M include/effects/SkEmbossMaskFilter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/effects/SkGradientShader.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkGroupShape.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/effects/SkLayerDrawLooper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/effects/SkLayerRasterizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 2 chunks +0 lines, -2 lines 0 comments Download
M include/effects/SkPixelXorXfermode.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/effects/SkRectShape.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/effects/SkTableColorFilter.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkFlattenable.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkPathEffect.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M src/core/SkShader.cpp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M src/effects/Sk2DPathEffect.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
D src/effects/SkEffects.cpp View 1 1 chunk +0 lines, -53 lines 0 comments Download
M src/effects/SkGradientShader.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/effects/SkTestImageFilters.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/ports/SkGlobalInitialization_chromium.cpp View 1 chunk +11 lines, -9 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 1 2 2 chunks +63 lines, -6 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 4
DerekS
12 years, 8 months ago (2012-03-23 13:00:02 UTC) #1
reed1
lgtm I especially like the changes where we just removed a macro from a header
12 years, 8 months ago (2012-03-23 13:37:03 UTC) #2
DerekS
On 2012/03/23 13:37:03, reed1 wrote: > lgtm > > I especially like the changes where ...
12 years, 8 months ago (2012-03-23 18:11:55 UTC) #3
reed1
12 years, 8 months ago (2012-03-23 18:16:36 UTC) #4
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b