In practice this define seems to never get set. (I set it once locally to ...
11 years, 2 months ago
(2012-03-23 00:34:37 UTC)
#1
In practice this define seems to never get set. (I set it once locally to make
sure everything works in that configuration.)
Since this doesn't seem to be necessary for tests to pass, maybe we can just
delete that whole MUTE_EXPECTED_ASSERTS business? (I lack the background for why
it's there.)
lgtm This stuff pre-dates me too, it was there before I open sourced the rlz ...
11 years, 2 months ago
(2012-03-23 14:35:07 UTC)
#2
lgtm
This stuff pre-dates me too, it was there before I open sourced the rlz code. I
had not noticed that it was never set though. Commit your change as is and
maybe later I can see if we can get rid of this or not. Thanks Nico.
Issue 5883056: Don't pay a static initializer for expected_assertion_ when it's not used.
(Closed)
Created 11 years, 2 months ago by thakis
Modified 11 years, 2 months ago
Reviewers: Roger Tawa, Roger Tawa (Google)
Base URL: https://rlz.googlecode.com/svn/trunk
Comments: 0