Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9434)

Issue 5883056: Don't pay a static initializer for expected_assertion_ when it's not used. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by thakis
Modified:
11 years, 11 months ago
CC:
rlz-codereviews_googlegroups.com
Base URL:
https://rlz.googlecode.com/svn/trunk
Visibility:
Public.

Description

Don't pay a static initializer for expected_assertion_ when it's not used. BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : git screwup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M lib/assert.h View 1 2 chunks +13 lines, -3 lines 0 comments Download
M lib/assert.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M lib/lib_values_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/string_utils_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2
thakis
In practice this define seems to never get set. (I set it once locally to ...
11 years, 11 months ago (2012-03-23 00:34:37 UTC) #1
Roger Tawa (Google)
11 years, 11 months ago (2012-03-23 14:35:07 UTC) #2
lgtm

This stuff pre-dates me too, it was there before I open sourced the rlz code.  I
had not noticed that it was never set though.  Commit your change as is and
maybe later I can see if we can get rid of this or not.  Thanks Nico.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b