Issue 5883056: Don't pay a static initializer for expected_assertion_ when it's not used.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5883056: Don't pay a static initializer for expected_assertion_ when it's not used. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by thakis

Modified:
11 years, 2 months ago

Reviewers:
Roger Tawa, Roger Tawa (Google)

CC:
rlz-codereviews_googlegroups.com

Base URL:
https://rlz.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Don't pay a static initializer for expected_assertion_ when it's not used. BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : git screwup #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -13 lines)			Patch
M	lib/assert.h	View	1	2 chunks	+13 lines, -3 lines	0 comments	Download
M	lib/assert.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/lib_values_unittest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/string_utils_unittest.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

thakis

In practice this define seems to never get set. (I set it once locally to ...

11 years, 2 months ago (2012-03-23 00:34:37 UTC) #1

Roger Tawa (Google)

11 years, 2 months ago (2012-03-23 14:35:07 UTC) #2

lgtm

This stuff pre-dates me too, it was there before I open sourced the rlz code.  I
had not noticed that it was never set though.  Commit your change as is and
maybe later I can see if we can get rid of this or not.  Thanks Nico.

Expand All Messages | Collapse All Messages