Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3280)

Issue 5882054: Minor cleanups. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by thakis
Modified:
12 years, 1 month ago
Reviewers:
willchan
CC:
rlz-codereviews_googlegroups.com
Base URL:
https://rlz.googlecode.com/svn/trunk
Visibility:
Public.

Description

Minor cleanups. BUG=none TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M lib/financial_ping.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M rlz.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
thakis
Addresses comments from https://codereview.appspot.com/5864055/ The thread screw-up is in chromium code, I'll cc you on ...
12 years, 1 month ago (2012-03-23 01:15:17 UTC) #1
willchan
12 years, 1 month ago (2012-03-23 01:28:53 UTC) #2
LGTM

On Thu, Mar 22, 2012 at 6:15 PM, <thakis@chromium.org> wrote:

> Reviewers: willchan,
>
> Message:
> Addresses comments from
https://codereview.appspot.**com/5864055/<https://codereview.appspot.com/5864...
>
> The thread screw-up is in chromium code, I'll cc you on the CL where I
> fix that (very likely tomorrow).
>
> Description:
> Minor cleanups.
>
> BUG=none
> TEST=none
>
>
> Please review this at
https://codereview.appspot.**com/5882054/<https://codereview.appspot.com/5882...
>
> Affected files:
>  M lib/financial_ping.cc
>  M rlz.gyp
>
>
> Index: lib/financial_ping.cc
> diff --git a/lib/financial_ping.cc b/lib/financial_ping.cc
> index 1c278bc10b20532bde742b14406f39**13427b1a0f..**
> 28ecd96f5964c61278da2353437e1a**6d0efbaff7 100644
> --- a/lib/financial_ping.cc
> +++ b/lib/financial_ping.cc
> @@ -278,8 +278,8 @@ bool FinancialPing::PingServer(**const char* request,
> std::string* response) {
>       GURL(url), content::URLFetcher::GET, &delegate));
>
>   fetcher->SetLoadFlags(net::**LOAD_DISABLE_CACHE |
> -                        net::LOAD_DO_NOT_SEND_AUTH_**DATA |  // XXX?
> -                        net::LOAD_DO_NOT_PROMPT_FOR_**LOGIN |  // XXX?
> +                        net::LOAD_DO_NOT_SEND_AUTH_**DATA |
> +                        net::LOAD_DO_NOT_PROMPT_FOR_**LOGIN |
>                         net::LOAD_DO_NOT_SEND_COOKIES |
>                         net::LOAD_DO_NOT_SAVE_COOKIES)**;
>
> Index: rlz.gyp
> diff --git a/rlz.gyp b/rlz.gyp
> index 12b6d2db73265a61faafccbaccfd93**46df522169..**
> e1aae72488ca35c725c9b881c91b4e**ece6afd35b 100644
> --- a/rlz.gyp
> +++ b/rlz.gyp
> @@ -81,8 +81,8 @@
>           ],
>           'dependencies': [
>             '../build/temp_gyp/googleurl.**gyp:googleurl',
> -            # TODO: This can change to just net once URLFetcher has moved
> -            # to net, http://118220
> +            '../net/net.gyp:net',
> +            # TODO: Remove this once URLFetcher has moved to net,
> http://118220
>             '../content/content.gyp:**content_common',
>           ],
>         }, {
>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b