code review 5882046: test: fix run.bash by spelling out the commands to use ...

test: fix run.bash by spelling out the commands to use for bug424.go

[iant, 2012-03-22 00:55:15]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2012-03-22 00:58:07]

http://codereview.appspot.com/5882046/diff/1/test/fixedbugs/bug424.go
File test/fixedbugs/bug424.go (right):

http://codereview.appspot.com/5882046/diff/1/test/fixedbugs/bug424.go#newcode1
test/fixedbugs/bug424.go:1: // $G $D/$F.dir/lib.go && $G $D/$F.go && $L $F.$A &&
./$A.out
I guess the $D is not needed for $L and $A.out ?

[iant2, 2012-03-22 04:28:32]

gri@golang.org writes:

> http://codereview.appspot.com/5882046/diff/1/test/fixedbugs/bug424.go#newcode1
> test/fixedbugs/bug424.go:1: // $G $D/$F.dir/lib.go && $G $D/$F.go && $L
> $F.$A && ./$A.out
> I guess the $D is not needed for $L and $A.out ?

Correct.

Ian

[gri, 2012-03-22 19:38:50]

LGTM
- gri

On Wed, Mar 21, 2012 at 5:55 PM,  <iant@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> test: fix run.bash by spelling out the commands to use for bug424.go
>
> Please review this at http://codereview.appspot.com/5882046/
>
> Affected files:
>  M test/fixedbugs/bug424.go
>  M test/golden.out
>
>
> Index: test/fixedbugs/bug424.go
> ===================================================================
> --- a/test/fixedbugs/bug424.go
> +++ b/test/fixedbugs/bug424.go
> @@ -1,4 +1,4 @@
> -// run
> +// $G $D/$F.dir/lib.go && $G $D/$F.go && $L $F.$A && ./$A.out
>
>  // Copyright 2012 The Go Authors.  All rights reserved.
>  // Use of this source code is governed by a BSD-style
> @@ -11,7 +11,7 @@
>
>  package main
>
> -import "./bug424.dir"
> +import "./lib"
>  import "reflect"
>  import "fmt"
>
> Index: test/golden.out
> ===================================================================
> --- a/test/golden.out
> +++ b/test/golden.out
> @@ -17,8 +17,5 @@
>
>  == bugs/
>
> -=========== bugs/424.go
> -BUG: myT3: lib.T.m called
> -
>  =========== bugs/bug395.go
>  bug395 is broken
>
>

[iant, 2012-03-22 19:48:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=5d7d9f1ed0b5 ***

test: fix run.bash by spelling out the commands to use for bug424.go

R=golang-dev, gri, iant
CC=golang-dev
http://codereview.appspot.com/5882046