Issue 5880043: Move rlz_test_helpers from win\test to test.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5880043: Move rlz_test_helpers from win\test to test. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by thakis

Modified:
13 years, 1 month ago

Reviewers:
Roger Tawa, Roger Tawa (Google)

CC:
rlz-codereviews_googlegroups.com

Base URL:
http://rlz.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Move rlz_test_helpers from win\test to test. Pure code move, no code change. TBR=rogerta Committed: https://code.google.com/p/rlz/source/detail?r=104

Patch Set 3 : #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -96 lines)			Patch
M	rlz.gyp	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	test/rlz_test_helpers.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	test/rlz_test_helpers.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	win/lib/financial_ping_test.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	win/lib/machine_deal_test.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
D	win/test/rlz_test_helpers.h	View		1 chunk	+0 lines, -24 lines	0 comments	Download
D	win/test/rlz_test_helpers.cc	View	1 2	1 chunk	+0 lines, -66 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

thakis

http://codereview.appspot.com/5880043/diff/1/rlz.gyp File rlz.gyp (right): http://codereview.appspot.com/5880043/diff/1/rlz.gyp#newcode87 rlz.gyp:87: 'test/rlz_test_helpers.h', Note these are still built only on windows ...

13 years, 1 month ago (2012-03-21 23:07:16 UTC) #1

lgtm

Expand All Messages | Collapse All Messages