Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(560)

Issue 5877062: code review 5877062: misc/dist: make godoc shortcut work (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by adg
Modified:
10 years, 8 months ago
Reviewers:
Joe Poirier
CC:
golang-dev
Visibility:
Public.

Description

misc/dist: make godoc shortcut work

Patch Set 1 #

Patch Set 2 : diff -r b385699f6593 https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M misc/dist/windows/installer.wxs View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
10 years, 8 months ago (2012-03-23 01:43:43 UTC) #1
adg
*** Submitted as http://code.google.com/p/go/source/detail?r=bce220d03774 *** misc/dist: make godoc shortcut work R=golang-dev CC=golang-dev http://codereview.appspot.com/5877062
10 years, 8 months ago (2012-03-23 01:44:39 UTC) #2
Joe Poirier
On Thu, Mar 22, 2012 at 8:43 PM, <adg@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > > ...
10 years, 8 months ago (2012-03-23 02:04:57 UTC) #3
adg
It works for me. You can test it, the binaries are up: http://code.google.com/p/go/downloads/list On 23 ...
10 years, 8 months ago (2012-03-23 02:06:19 UTC) #4
Joe Poirier
On Thu, Mar 22, 2012 at 9:05 PM, Andrew Gerrand <adg@golang.org> wrote: > It works ...
10 years, 8 months ago (2012-03-23 02:15:25 UTC) #5
Joe Poirier
On Thu, Mar 22, 2012 at 9:14 PM, Joseph Poirier <jdpoirier@gmail.com> wrote: > On Thu, ...
10 years, 8 months ago (2012-03-23 02:44:19 UTC) #6
adg
10 years, 8 months ago (2012-03-23 02:50:30 UTC) #7
Thanks very much for testing it. The bug I found in godoc was that it
didn't like GOROOTs with a trailing slash. Will file an issue.

On Friday, March 23, 2012, Joseph Poirier wrote:

> On Thu, Mar 22, 2012 at 9:14 PM, Joseph Poirier
<jdpoirier@gmail.com<javascript:;>>
> wrote:
> > On Thu, Mar 22, 2012 at 9:05 PM, Andrew Gerrand
<adg@golang.org<javascript:;>>
> wrote:
> >> It works for me. You can test it, the binaries are up:
> >> http://code.google.com/p/go/downloads/list
> >>
> > It depends what you run it on 2k\XP\7, 7 seems to be the most
> > forgiving, but I don't think it's a big deal.
> > -joe
>
> Just checked, works on all three systems.
>
> LOL - from the Microsoft documentation
>
> Using multiple commands
> You can use multiple commands separated by the command separator &&
> for string, but you must enclose them in quotation marks (for example,
> "command&&command&&command").
>
>
> so much for following directions. :)
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b