Move GetMachineId() to its own file.

Move GetMachineId() to its own file.

The sha1 logic is now shared cross-platform which calls out to a
platform-specific function to get system data.

GetMachineId() now returns a string instead of a wstring. The SID
is still a string16 instead of a wstring, which is the same on windows.
(I considered making it a string too, but considered it too risky since
if a wide character creeps in somehow it'd change the SHA result.)

The platform-specific implementation on mac is still empty.

BUG=none
TEST=none

[thakis, 2012-03-22 20:37:00]

Many files touched, but most files have just 1-4 lines changed. The windows code
was just moved around.

https://codereview.appspot.com/5877053/diff/3036/lib/machine_id_unittest.cc
File lib/machine_id_unittest.cc (right):

https://codereview.appspot.com/5877053/diff/3036/lib/machine_id_unittest.cc#n...
lib/machine_id_unittest.cc:18:
EXPECT_STREQ("A341BA986A7E86840688977FCF20C86E253F00919E068B50F8",
Note: This number did not change.

[Roger Tawa (Google), 2012-03-22 21:23:53]

Hi Nico,

A few questions below.  Is *very* important that the machine id not change.  The
code looks good, but it would be good to have QA double check.  Once you roll
the chrome deps to include this change, let me know the first chrome version
number that includes it and then I'll make sure the QA folks try it out.

https://codereview.appspot.com/5877053/diff/3036/lib/machine_id.cc
File lib/machine_id.cc (right):

https://codereview.appspot.com/5877053/diff/3036/lib/machine_id.cc#newcode76
lib/machine_id.cc:76: }
functions not is same order as header.

https://codereview.appspot.com/5877053/diff/3036/lib/machine_id.h
File lib/machine_id.h (right):

https://codereview.appspot.com/5877053/diff/3036/lib/machine_id.h#newcode28
lib/machine_id.h:28: }  // namespace testing
is it ok to use this namespace name here?

https://codereview.appspot.com/5877053/diff/3036/rlz.gyp
File rlz.gyp (right):

https://codereview.appspot.com/5877053/diff/3036/rlz.gyp#newcode121
rlz.gyp:121: 'win/lib/machine_deal_test.cc',
is this file missing from this CL?

[thakis, 2012-03-22 21:33:00]

Thanks!

https://codereview.appspot.com/5877053/diff/3036/lib/machine_id.cc
File lib/machine_id.cc (right):

https://codereview.appspot.com/5877053/diff/3036/lib/machine_id.cc#newcode76
lib/machine_id.cc:76: }
On 2012/03/22 21:23:53, rogerta wrote:
> functions not is same order as header.

Done.

https://codereview.appspot.com/5877053/diff/3036/lib/machine_id.h
File lib/machine_id.h (right):

https://codereview.appspot.com/5877053/diff/3036/lib/machine_id.h#newcode28
lib/machine_id.h:28: }  // namespace testing
On 2012/03/22 21:23:53, rogerta wrote:
> is it ok to use this namespace name here?

Added an enclosing "rlz_lib" namespace just in case.

https://codereview.appspot.com/5877053/diff/3036/rlz.gyp
File rlz.gyp (right):

https://codereview.appspot.com/5877053/diff/3036/rlz.gyp#newcode121
rlz.gyp:121: 'win/lib/machine_deal_test.cc',
On 2012/03/22 21:23:53, rogerta wrote:
> is this file missing from this CL?

Whoops, yes. Added.

[Roger Tawa (Google), 2012-03-22 22:22:44]

lgtm

Thanks Nico.  Don't forget to let me know the first build that has these
changes.