Looks good Nico. For the gyp file, isn't the convention to only remove files conditionally ...
11 years, 6 months ago
(2012-03-23 14:21:59 UTC)
#2
Looks good Nico. For the gyp file, isn't the convention to only remove files
conditionally and not add files conditionally? Also, if you name the files in a
particular way, doesn't gyp automatically remove them from building on
particular platforms?
On 2012/03/23 14:21:59, rogerta wrote: > Looks good Nico. For the gyp file, isn't the ...
11 years, 6 months ago
(2012-03-23 14:27:42 UTC)
#3
On 2012/03/23 14:21:59, rogerta wrote:
> Looks good Nico. For the gyp file, isn't the convention to only remove files
> conditionally and not add files conditionally?
We do both in different places. With the "add all, then remove" approach, the
removed files still show up in msvc. Some msvc users like having mac and linux
files in their file list.
> Also, if you name the files in a
> particular way, doesn't gyp automatically remove them from building on
> particular platforms?
Yes, but that requires setting 'chromium_code': 1 in the variables section. That
also turns on warnings as errors and tweaks a few warnings.
I can do both these things, but I'll do them in another CL since it's something
unrelated if that's ok.
Issue 5875051: Rename rlz_lib2.cc and win/lib/rlz_lib.cc to win/lib/rlz_lib_win.cc
(Closed)
Created 11 years, 6 months ago by thakis
Modified 11 years, 6 months ago
Reviewers: Roger Tawa, Roger Tawa (Google)
Base URL: https://rlz.googlecode.com/svn/trunk
Comments: 0