Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(188)

Issue 5875051: Rename rlz_lib2.cc and win/lib/rlz_lib.cc to win/lib/rlz_lib_win.cc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 12 months ago by thakis
Modified:
10 years, 12 months ago
CC:
rlz-codereviews_googlegroups.com
Base URL:
https://rlz.googlecode.com/svn/trunk
Visibility:
Public.

Description

Rename rlz_lib2.cc and win/lib/rlz_lib.cc to win/lib/rlz_lib_win.cc BUG=none TEST=none TBR=rogerta

Patch Set 1 #

Patch Set 2 : compile on win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -976 lines) Patch
M lib/financial_ping_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M lib/lib_values.h View 1 chunk +1 line, -1 line 0 comments Download
A + lib/rlz_lib.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D lib/rlz_lib2.cc View 1 chunk +0 lines, -711 lines 0 comments Download
M rlz.gyp View 2 chunks +2 lines, -4 lines 0 comments Download
M win/lib/rlz_lib.h View 1 chunk +4 lines, -3 lines 0 comments Download
D win/lib/rlz_lib.cc View 1 chunk +0 lines, -259 lines 0 comments Download
A + win/lib/rlz_lib_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M win/lib/rlz_value_store_registry.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
thakis
Purely cleanup, no functionality change.
10 years, 12 months ago (2012-03-22 22:53:20 UTC) #1
Roger Tawa (Google)
Looks good Nico. For the gyp file, isn't the convention to only remove files conditionally ...
10 years, 12 months ago (2012-03-23 14:21:59 UTC) #2
thakis
On 2012/03/23 14:21:59, rogerta wrote: > Looks good Nico. For the gyp file, isn't the ...
10 years, 12 months ago (2012-03-23 14:27:42 UTC) #3
Roger Tawa (Google)
10 years, 12 months ago (2012-03-23 15:31:05 UTC) #4
lgtm

Thanks Nico.  I think both would be good to have in a separate CL.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b