Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(496)

Issue 5875049: [PDF] Move most of the headers to be private. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by Steve VanDeBogart
Modified:
12 years, 3 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

[PDF] Move most of the headers to be private. Compute font stats in SkPDFDocument in order to make more of the headers private. Previous review: https://codereview.appspot.com/5868049/ Committed: https://code.google.com/p/skia/source/detail?r=3470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1276 lines) Patch
M gyp/pdf.gyp View 1 chunk +10 lines, -10 lines 0 comments Download
M gyp/tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
D include/pdf/SkPDFCatalog.h View 1 chunk +0 lines, -137 lines 0 comments Download
M include/pdf/SkPDFDocument.h View 2 chunks +7 lines, -4 lines 0 comments Download
D include/pdf/SkPDFFont.h View 1 chunk +0 lines, -202 lines 0 comments Download
D include/pdf/SkPDFFormXObject.h View 1 chunk +0 lines, -48 lines 0 comments Download
D include/pdf/SkPDFGraphicState.h View 1 chunk +0 lines, -101 lines 0 comments Download
D include/pdf/SkPDFImage.h View 1 chunk +0 lines, -70 lines 0 comments Download
D include/pdf/SkPDFPage.h View 1 chunk +0 lines, -100 lines 0 comments Download
D include/pdf/SkPDFShader.h View 1 chunk +0 lines, -65 lines 0 comments Download
D include/pdf/SkPDFStream.h View 1 chunk +0 lines, -75 lines 0 comments Download
D include/pdf/SkPDFTypes.h View 1 chunk +0 lines, -403 lines 0 comments Download
D include/pdf/SkPDFUtils.h View 1 chunk +0 lines, -54 lines 0 comments Download
A + src/pdf/SkPDFCatalog.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDocument.cpp View 2 chunks +19 lines, -3 lines 0 comments Download
A + src/pdf/SkPDFFont.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + src/pdf/SkPDFFormXObject.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/pdf/SkPDFGraphicState.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/pdf/SkPDFImage.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/pdf/SkPDFPage.h View 1 chunk +1 line, -1 line 0 comments Download
A + src/pdf/SkPDFShader.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/pdf/SkPDFStream.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/pdf/SkPDFTypes.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/pdf/SkPDFUtils.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2
Steve VanDeBogart
12 years, 3 months ago (2012-03-22 17:41:47 UTC) #1
epoger
12 years, 3 months ago (2012-03-22 19:05:59 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b