Move SkBitSet to utils.

Move SkBitSet to utils.

Committed: https://code.google.com/p/skia/source/detail?r=3460

[Steve VanDeBogart, 2012-03-21 20:52:12]

It's funny for the xps module to depend on the pdf module.  Moving SkBitSet to
core will fix that.

https://codereview.appspot.com/5875043/diff/1/include/core/SkBitSet.h
File include/core/SkBitSet.h (right):

https://codereview.appspot.com/5875043/diff/1/include/core/SkBitSet.h#newcode2
include/core/SkBitSet.h:2: /*
Alternatively this can go into src/core/SkBitSet.h since it's not used by a
public interface.  I put it here because it's used by two different gyp modules.

[bungeman, 2012-03-21 21:09:34]

On 2012/03/21 20:52:12, Steve VanDeBogart wrote:
> It's funny for the xps module to depend on the pdf module.  Moving SkBitSet to
> core will fix that.
> 
> https://codereview.appspot.com/5875043/diff/1/include/core/SkBitSet.h
> File include/core/SkBitSet.h (right):
> 
> https://codereview.appspot.com/5875043/diff/1/include/core/SkBitSet.h#newcode2
> include/core/SkBitSet.h:2: /*
> Alternatively this can go into src/core/SkBitSet.h since it's not used by a
> public interface.  I put it here because it's used by two different gyp
modules.

Utils is a better place for common code which core itself does not rely on. The
header should also be in utils/src, much like SkBase64.

[Steve VanDeBogart, 2012-03-21 21:47:00]

On 2012/03/21 21:09:34, bungeman wrote:
> On 2012/03/21 20:52:12, Steve VanDeBogart wrote:
> > It's funny for the xps module to depend on the pdf module.  Moving SkBitSet
to
> > core will fix that.
> > 
> > https://codereview.appspot.com/5875043/diff/1/include/core/SkBitSet.h
> > File include/core/SkBitSet.h (right):
> > 
> >
https://codereview.appspot.com/5875043/diff/1/include/core/SkBitSet.h#newcode2
> > include/core/SkBitSet.h:2: /*
> > Alternatively this can go into src/core/SkBitSet.h since it's not used by a
> > public interface.  I put it here because it's used by two different gyp
> modules.
> 
> Utils is a better place for common code which core itself does not rely on.
The
> header should also be in utils/src, much like SkBase64.

Done.

[bungeman, 2012-03-21 22:52:21]

Except for adding the missing dependencies, LGTM.

http://codereview.appspot.com/5875043/diff/4001/gyp/pdf.gyp
File gyp/pdf.gyp (right):

http://codereview.appspot.com/5875043/diff/4001/gyp/pdf.gyp#newcode9
gyp/pdf.gyp:9: ],
While adding dependencies to pdf, we should add zlib and ports.

On linux, build all, go to ${skia}/out/Debug/obj.target/gyp and

dot -Tps <(echo "digraph Skia {"; lorder `ls *.a` | sort | uniq | sed 's/ / ->
/;s/\.a//g'; echo "}") -o ~/Skia.ps

If you have graphviz and lorder (from bsdmainutils) then you get a graph of the
dependencies. Or you could just stare at

lorder `ls *.a` | sort | uniq

I'm currently in the process of getting rid of the circular dependencies.

[Steve VanDeBogart, 2012-03-21 23:09:43]

http://codereview.appspot.com/5875043/diff/4001/gyp/pdf.gyp
File gyp/pdf.gyp (right):

http://codereview.appspot.com/5875043/diff/4001/gyp/pdf.gyp#newcode9
gyp/pdf.gyp:9: ],
On 2012/03/21 22:52:21, bungeman wrote:
> While adding dependencies to pdf, we should add zlib and ports.
> 
> On linux, build all, go to ${skia}/out/Debug/obj.target/gyp and
> 
> dot -Tps <(echo "digraph Skia {"; lorder `ls *.a` | sort | uniq | sed 's/ / ->
> /;s/\.a//g'; echo "}") -o ~/Skia.ps
> 
> If you have graphviz and lorder (from bsdmainutils) then you get a graph of
the
> dependencies. Or you could just stare at
> 
> lorder `ls *.a` | sort | uniq
> 
> I'm currently in the process of getting rid of the circular dependencies.

Done.