Issue 5874061: mac: Implement the locking part of ScopedRlzValueStoreLock.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5874061: mac: Implement the locking part of ScopedRlzValueStoreLock. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by thakis

Modified:
12 years, 1 month ago

Reviewers:
Mark Mentovai

CC:
rlz-codereviews_googlegroups.com, Roger Tawa

Base URL:
https://rlz.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

mac: Implement the locking part of ScopedRlzValueStoreLock. BUG=chromium:117738 TEST=none

Patch Set 1 #

Patch Set 2 : recursive #

Patch Set 3 : code complete #

Patch Set 4 : refactor #

Patch Set 5 : tweak #

Total comments: 2

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -5 lines)			Patch
	M	lib/rlz_value_store.h	View	1 2	2 chunks	+7 lines, -2 lines	2 comments	Download
	M	mac/lib/rlz_value_store_mac.mm	View	1 2 3 4	5 chunks	+117 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thakis

I believe that's the last missing bit for rlz/mac. (At least one moreCL is needed ...

12 years, 1 month ago (2012-03-23 21:44:30 UTC) #1

Mark Mentovai

LGTM Yes, I took my time on this and tried to break it. https://codereview.appspot.com/5874061/diff/7001/lib/rlz_value_store.h File ...

12 years, 1 month ago (2012-03-23 22:03:49 UTC) #2

thakis

12 years, 1 month ago (2012-03-23 22:23:23 UTC) #3

Thanks!

https://codereview.appspot.com/5874061/diff/7001/lib/rlz_value_store.h
File lib/rlz_value_store.h (right):

https://codereview.appspot.com/5874061/diff/7001/lib/rlz_value_store.h#newcode81
lib/rlz_value_store.h:81: // resursively. That is, all user code should look
like this:
On 2012/03/23 22:03:50, Mark Mentovai wrote:
> recursively?

Done.

Expand All Messages | Collapse All Messages