code review 5874053: cmd/gc: fix comment typo, assignment spacing

cmd/gc: fix comment typo, assignment spacing

[iant, 2012-03-22 17:57:52]

Hello bradfitz (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2012-03-22 18:01:39]

LGTM

On Thu, Mar 22, 2012 at 10:57 AM,  <iant@golang.org> wrote:
> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/gc: fix comment typo, assignment spacing
>
> Please review this at http://codereview.appspot.com/5874053/
>
> Affected files:
>  M src/cmd/gc/walk.c
>
>
> Index: src/cmd/gc/walk.c
> ===================================================================
> --- a/src/cmd/gc/walk.c
> +++ b/src/cmd/gc/walk.c
> @@ -2358,10 +2358,10 @@
>
>        walkexprlistsafe(n->list, init);
>
> -       // walkexprlistsafe will leave OINDEX (s[n]) along if both s
> +       // walkexprlistsafe will leave OINDEX (s[n]) alone if both s
>        // and n are name or literal, but those may index the slice we're
>        // modifying here.  Fix explicitly.
> -       for(l = n->list; l; l=l->next)
> +       for(l=n->list; l; l=l->next)
>                l->n = cheapexpr(l->n, init);
>
>        nsrc = n->list->n;
>
>

[bradfitz, 2012-03-22 18:03:00]

LGTM

On Thu, Mar 22, 2012 at 10:57 AM, <iant@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/gc: fix comment typo, assignment spacing
>
> Please review this at
http://codereview.appspot.com/**5874053/<http://codereview.appspot.com/5874053/>
>
> Affected files:
>  M src/cmd/gc/walk.c
>
>
> Index: src/cmd/gc/walk.c
> ==============================**==============================**=======
> --- a/src/cmd/gc/walk.c
> +++ b/src/cmd/gc/walk.c
> @@ -2358,10 +2358,10 @@
>
>        walkexprlistsafe(n->list, init);
>
> -       // walkexprlistsafe will leave OINDEX (s[n]) along if both s
> +       // walkexprlistsafe will leave OINDEX (s[n]) alone if both s
>        // and n are name or literal, but those may index the slice we're
>        // modifying here.  Fix explicitly.
> -       for(l = n->list; l; l=l->next)
> +       for(l=n->list; l; l=l->next)
>                l->n = cheapexpr(l->n, init);
>
>        nsrc = n->list->n;
>
>
>

[lvd, 2012-03-22 18:33:50]

LGTM sorry this was all my fault.

On Thu, Mar 22, 2012 at 19:02, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> LGTM
>
> On Thu, Mar 22, 2012 at 10:57 AM, <iant@golang.org> wrote:
>
>> Reviewers: bradfitz,
>>
>> Message:
>> Hello bradfitz (cc: golang-dev@googlegroups.com),
>>
>> I'd like you to review this change to
>> https://go.googlecode.com/hg/
>>
>>
>> Description:
>> cmd/gc: fix comment typo, assignment spacing
>>
>> Please review this at
http://codereview.appspot.com/**5874053/<http://codereview.appspot.com/5874053/>
>>
>> Affected files:
>>  M src/cmd/gc/walk.c
>>
>>
>> Index: src/cmd/gc/walk.c
>> ==============================**==============================**=======
>> --- a/src/cmd/gc/walk.c
>> +++ b/src/cmd/gc/walk.c
>> @@ -2358,10 +2358,10 @@
>>
>>        walkexprlistsafe(n->list, init);
>>
>> -       // walkexprlistsafe will leave OINDEX (s[n]) along if both s
>> +       // walkexprlistsafe will leave OINDEX (s[n]) alone if both s
>>        // and n are name or literal, but those may index the slice we're
>>        // modifying here.  Fix explicitly.
>> -       for(l = n->list; l; l=l->next)
>> +       for(l=n->list; l; l=l->next)
>>                l->n = cheapexpr(l->n, init);
>>
>>        nsrc = n->list->n;
>>
>>
>>
>

[iant, 2012-03-22 18:40:16]

*** Submitted as http://code.google.com/p/go/source/detail?r=0d4324e5a047 ***

cmd/gc: fix comment typo, assignment spacing

R=bradfitz, gri, lvd
CC=golang-dev
http://codereview.appspot.com/5874053