Issue 5868049: [PDF] Move most of the headers to be private.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5868049: [PDF] Move most of the headers to be private. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by Steve VanDeBogart

Modified:
12 years, 3 months ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

[PDF] Move most of the headers to be private. Compute font stats in SkPDFDocument in order to make more of the headers private. Previous review: https://codereview.appspot.com/5865048/ Committed: https://code.google.com/p/skia/source/detail?r=3457

Patch Set 1 #

Patch Set 2 : Fix tests target compile #

Patch Set 3 : Fix typo/thinko #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -1343 lines)			Patch
M	gyp/tests.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
D	include/pdf/SkBitSet.h	View		1 chunk	+0 lines, -78 lines	0 comments	Download
D	include/pdf/SkPDFCatalog.h	View		1 chunk	+0 lines, -137 lines	0 comments	Download
M	include/pdf/SkPDFDocument.h	View		2 chunks	+7 lines, -4 lines	0 comments	Download
D	include/pdf/SkPDFFont.h	View		1 chunk	+0 lines, -202 lines	0 comments	Download
D	include/pdf/SkPDFFormXObject.h	View		1 chunk	+0 lines, -48 lines	0 comments	Download
D	include/pdf/SkPDFGraphicState.h	View		1 chunk	+0 lines, -101 lines	0 comments	Download
D	include/pdf/SkPDFImage.h	View		1 chunk	+0 lines, -70 lines	0 comments	Download
D	include/pdf/SkPDFPage.h	View		1 chunk	+0 lines, -100 lines	0 comments	Download
D	include/pdf/SkPDFShader.h	View		1 chunk	+0 lines, -65 lines	0 comments	Download
D	include/pdf/SkPDFStream.h	View		1 chunk	+0 lines, -75 lines	0 comments	Download
D	include/pdf/SkPDFTypes.h	View		1 chunk	+0 lines, -403 lines	0 comments	Download
D	include/pdf/SkPDFUtils.h	View		1 chunk	+0 lines, -54 lines	0 comments	Download
A +	src/pdf/SkBitSet.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/pdf/SkPDFCatalog.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pdf/SkPDFDocument.cpp	View	1 2	2 chunks	+19 lines, -3 lines	0 comments	Download
A +	src/pdf/SkPDFFont.h	View		4 chunks	+9 lines, -9 lines	0 comments	Download
A +	src/pdf/SkPDFFormXObject.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/pdf/SkPDFGraphicState.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/pdf/SkPDFImage.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/pdf/SkPDFPage.h	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	src/pdf/SkPDFShader.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/pdf/SkPDFStream.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/pdf/SkPDFTypes.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	src/pdf/SkPDFUtils.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Steve VanDeBogart

Mike already approved patch set 1, patch set 2 just fixes the compile.

12 years, 3 months ago (2012-03-21 18:05:00 UTC) #1

LGTM

I am in favor of successful compilation

Expand All Messages | Collapse All Messages