Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(84)

Issue 5867045: code review 5867045: sort: add time complexity to doc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 12 months ago by Stefan Nilsson
Modified:
12 years, 11 months ago
Reviewers:
CC:
golang-dev, gri
Visibility:
Public.

Description

sort: add time complexity to doc Let's tell the world that Go's sort is O(n log n). Surely this is a feature we intend to keep.

Patch Set 1 #

Patch Set 2 : diff -r 87d50a70f7d2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 87d50a70f7d2 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 7e4c7879d395 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/pkg/sort/sort.go View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5
Stefan Nilsson
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 12 months ago (2012-03-20 22:21:02 UTC) #1
gri
Please rephrase a bit. http://codereview.appspot.com/5867045/diff/3002/src/pkg/sort/sort.go File src/pkg/sort/sort.go (right): http://codereview.appspot.com/5867045/diff/3002/src/pkg/sort/sort.go#newcode188 src/pkg/sort/sort.go:188: // It makes O(n log(n)), ...
12 years, 11 months ago (2012-03-21 20:46:57 UTC) #2
Stefan Nilsson
Hello golang-dev@googlegroups.com, gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 11 months ago (2012-03-22 15:46:16 UTC) #3
gri
LGTM thanks. - gri
12 years, 11 months ago (2012-03-22 16:26:42 UTC) #4
gri
12 years, 11 months ago (2012-03-22 16:27:07 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=0ec67c4df6bd ***

sort: add time complexity to doc

Let's tell the world that Go's sort is O(n log n).
Surely this is a feature we intend to keep.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5867045

Committer: Robert Griesemer <gri@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b