Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(203)

Issue 5862043: Make rlz_lib_test.cc and financial_ping_test.cc build on mac. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by thakis
Modified:
12 years, 2 months ago
CC:
rlz-codereviews_googlegroups.com
Base URL:
http://rlz.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Make rlz_lib_test.cc and financial_ping_test.cc build on mac. Committed: https://code.google.com/p/rlz/source/detail?r=101

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -20 lines) Patch
M win/lib/financial_ping_test.cc View 10 chunks +27 lines, -9 lines 1 comment Download
M win/lib/rlz_lib_test.cc View 7 chunks +37 lines, -11 lines 1 comment Download

Messages

Total messages: 4
thakis
Note that this only makes it possible to build these on mac. They aren't compiled ...
12 years, 2 months ago (2012-03-20 19:40:35 UTC) #1
Roger Tawa (Google)
Is the plan to eventually remove these #ifdef? why not implement the MachineDeal class before ...
12 years, 2 months ago (2012-03-20 20:12:24 UTC) #2
thakis
On 2012/03/20 20:12:24, rogerta wrote: > Is the plan to eventually remove these #ifdef? why ...
12 years, 2 months ago (2012-03-20 20:14:41 UTC) #3
Roger Tawa (Google)
12 years, 2 months ago (2012-03-20 20:20:06 UTC) #4
lgtm

OK, makes sense about machine deals.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b