Note that this only makes it possible to build these on mac. They aren't compiled ...
12 years, 2 months ago
(2012-03-20 19:40:35 UTC)
#1
Note that this only makes it possible to build these on mac. They aren't
compiled on mac yet because the tests don't pass yet (due to RlzValueStoreMac
being only a collection of NOTIMPLEMENTED()s).
On 2012/03/20 20:12:24, rogerta wrote: > Is the plan to eventually remove these #ifdef? why ...
12 years, 2 months ago
(2012-03-20 20:14:41 UTC)
#3
On 2012/03/20 20:12:24, rogerta wrote:
> Is the plan to eventually remove these #ifdef? why not implement the
> MachineDeal class before updating these tests?
My understanding was that MachineDeal isn't necessary on mac, since we won't
support machine deals on mac. I thought that's only used for OEM deals. Is that
not correct?
(I do plan to implement GetMachineId(), but not the rest.)
Issue 5862043: Make rlz_lib_test.cc and financial_ping_test.cc build on mac.
(Closed)
Created 12 years, 2 months ago by thakis
Modified 12 years, 2 months ago
Reviewers: Roger Tawa, Roger Tawa (Google)
Base URL: http://rlz.googlecode.com/svn/trunk/
Comments: 2