Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(530)

Issue 5852043: code review 5852043: build: unset GOPATH before tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by minux1
Modified:
7 years, 8 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

build: unset GOPATH before tests This is because we disallow local import for non-local packages, if GOROOT happens to be under one of GOPATH, then some tests will fail to build. Fixes issue 3337.

Patch Set 1 #

Patch Set 2 : diff -r b5a8aeb000eb https://code.google.com/p/go/ #

Patch Set 3 : diff -r b5a8aeb000eb https://code.google.com/p/go/ #

Total comments: 3

Patch Set 4 : diff -r fbc982f5aff1 https://code.google.com/p/go #

Patch Set 5 : diff -r a01526dcd58e https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/run.bash View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/run.bat View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
7 years, 8 months ago (2012-03-17 10:25:01 UTC) #1
r
LGTM http://codereview.appspot.com/5852043/diff/5001/src/run.bash File src/run.bash (right): http://codereview.appspot.com/5852043/diff/5001/src/run.bash#newcode11 src/run.bash:11: unset GOPATH # we disallow local import for ...
7 years, 8 months ago (2012-03-19 20:49:50 UTC) #2
minux1
7 years, 8 months ago (2012-03-20 16:47:35 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=ea6f7454edbb ***

build: unset GOPATH before tests
This is because we disallow local import for non-local packages, if
GOROOT happens to be under one of GOPATH, then some tests will fail
to build.
Fixes issue 3337.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5852043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b