Issue 58500044: Issue 1566: Remove references to registration key

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 58500044: Issue 1566: Remove references to registration key (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by arnold.koroa

Modified:
10 years, 7 months ago

Reviewers:
damith

Visibility:
Public.

More Reviews

Description

Issue 1566: Remove references to registration key

Patch Set 1 #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -17 lines)			Patch
M	src/main/java/teammates/logic/core/AccountsLogic.java	View	3 chunks	+16 lines, -3 lines	0 comments	Download
M	src/main/java/teammates/ui/controller/StudentCourseJoinAuthenticatedAction.java	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/main/webapp/jsp/instructorCourseStudentDetails.jsp	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/test/java/teammates/test/cases/logic/AccountsLogicTest.java	View	3 chunks	+12 lines, -4 lines	0 comments	Download
M	src/test/java/teammates/test/cases/ui/browsertests/InstructorCourseStudentDetailsPageUiTest.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/test/resources/pages/InstructorCourseStudentDetailsPage.html	View	1 chunk	+2 lines, -2 lines	2 comments	Download
M	src/test/resources/pages/InstructorCourseStudentDetailsUnregisteredPage.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/test/resources/pages/StudentHomeInvalidKey.html	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

damith

https://codereview.appspot.com/58500044/diff/1/src/test/resources/pages/InstructorCourseStudentDetailsPage.html File src/test/resources/pages/InstructorCourseStudentDetailsPage.html (right): https://codereview.appspot.com/58500044/diff/1/src/test/resources/pages/InstructorCourseStudentDetailsPage.html#newcode99 src/test/resources/pages/InstructorCourseStudentDetailsPage.html:99: <td id="regkey">http://{*}.appspot.com/page/studentCourseJoin?regkey={*}</td> may http://{*}/page/... ? otherwise we cannot set ...

10 years, 7 months ago (2014-01-30 03:19:04 UTC) #1

arnold.koroa

10 years, 7 months ago (2014-01-30 03:29:00 UTC) #2

https://codereview.appspot.com/58500044/diff/1/src/test/resources/pages/Instr...
File src/test/resources/pages/InstructorCourseStudentDetailsPage.html (right):

https://codereview.appspot.com/58500044/diff/1/src/test/resources/pages/Instr...
src/test/resources/pages/InstructorCourseStudentDetailsPage.html:99: <td
id="regkey">http://{*}.appspot.com/page/studentCourseJoin?regkey={*}</td>
On 2014/01/30 03:19:05, damith wrote:
> may http://{*}/page/... ?
> otherwise we cannot set it to point to dev server if we want to.

Done.

Expand All Messages | Collapse All Messages