Issue 5847065: JAVA: Exclude TestMetadataTestCase from test cases.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5847065: JAVA: Exclude TestMetadataTestCase from test cases. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by pliard1

Modified:
12 years, 1 month ago

Reviewers:
lararennie, shaopengjia

Base URL:
https://libphonenumber.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

JAVA: Exclude TestMetadataTestCase from test cases. Committed: https://code.google.com/p/libphonenumber/source/detail?r=432

Patch Set 2 : Update #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	java/pom.xml	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

lararennie

http://codereview.appspot.com/5847065/diff/1/java/pom.xml File java/pom.xml (right): http://codereview.appspot.com/5847065/diff/1/java/pom.xml#newcode95 java/pom.xml:95: <exclude>**/TestMetadataTestCase.java</exclude> Why not <includes> <include>**/*Test.java</include> </includes> instead? Just to ...

12 years, 1 month ago (2012-03-19 10:34:22 UTC) #2

pliard1

http://codereview.appspot.com/5847065/diff/1/java/pom.xml File java/pom.xml (right): http://codereview.appspot.com/5847065/diff/1/java/pom.xml#newcode95 java/pom.xml:95: <exclude>**/TestMetadataTestCase.java</exclude> On 2012/03/19 10:34:22, lararennie wrote: > Why not ...

12 years, 1 month ago (2012-03-19 11:08:40 UTC) #3

LGTM

Expand All Messages | Collapse All Messages