Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(82)

Issue 5845067: code review 5845067: crypto/tls: always send a Certificate message if one wa... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by agl1
Modified:
8 years ago
Reviewers:
CC:
golang-dev, r, ality
Visibility:
Public.

Description

crypto/tls: always send a Certificate message if one was requested. If a CertificateRequest is received we have to reply with a Certificate message, even if we don't have a certificate to offer. Fixes issue 3339.

Patch Set 1 #

Patch Set 2 : diff -r 0a5692d60e01 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0a5692d60e01 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0a5692d60e01 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r c47b0caa500e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/pkg/crypto/tls/handshake_client.go View 1 2 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 4
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
8 years ago (2012-03-18 22:55:30 UTC) #1
r
LGTM,nervously
8 years ago (2012-03-18 23:09:56 UTC) #2
ality
LGTM Aside from the comment this is the exact same change that I made. Same ...
8 years ago (2012-03-19 01:25:59 UTC) #3
agl1
8 years ago (2012-03-19 16:35:12 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=0002f1f792e0 ***

crypto/tls: always send a Certificate message if one was requested.

If a CertificateRequest is received we have to reply with a
Certificate message, even if we don't have a certificate to offer.

Fixes issue 3339.

R=golang-dev, r, ality
CC=golang-dev
http://codereview.appspot.com/5845067
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b