Issue 5845050: Add os_posix gyp variable, nesting variables dicts as needed to do so.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5845050: Add os_posix gyp variable, nesting variables dicts as needed to do so. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by epoger

Modified:
12 years, 9 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com, bungeman, robertphillips

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add os_posix gyp variable, nesting variables dicts as needed to do so. Committed: https://code.google.com/p/skia/source/detail?r=3418

Patch Set 1 #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -12 lines)			Patch
	M	gyp/common.gypi	View		2 chunks	+4 lines, -12 lines	0 comments	Download
	A	gyp/common_variables.gypi	View		1 chunk	+80 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

epoger

Here's the more Chromium-y approach... it's actually not as bad as I had feared. I ...

12 years, 9 months ago (2012-03-16 18:10:15 UTC) #1

bsalomon

12 years, 9 months ago (2012-03-16 18:19:14 UTC) #2

On 2012/03/16 18:10:15, epoger wrote:
> Here's the more Chromium-y approach... it's actually not as bad as I had
feared.
> I think the comments help.  (Please note any additional/modified comments that
> could improve it.)

The comments do help.

LGTM, now hand me a bucket to throw up in.

Expand All Messages | Collapse All Messages