Set the custom font in ui.gtk3.CandidatePanel.

Set the custom font in ui.gtk3.CandidatePanel.


BUG=RH#803250
TEST=Linux desktop

[Peng, 2012-03-16 12:37:03]

https://codereview.appspot.com/5845047/diff/3001/ui/gtk3/candidatearea.vala
File ui/gtk3/candidatearea.vala (right):

https://codereview.appspot.com/5845047/diff/3001/ui/gtk3/candidatearea.vala#n...
ui/gtk3/candidatearea.vala:248: private void udpate_label_font () {
Is it possible to override the default font for whole application with one
function call instead for each labels?

[fujiwara, 2012-03-19 11:38:55]

On 2012/03/16 12:37:03, Peng wrote:
> https://codereview.appspot.com/5845047/diff/3001/ui/gtk3/candidatearea.vala
> File ui/gtk3/candidatearea.vala (right):
> 
>
https://codereview.appspot.com/5845047/diff/3001/ui/gtk3/candidatearea.vala#n...
> ui/gtk3/candidatearea.vala:248: private void udpate_label_font () {
> Is it possible to override the default font for whole application with one
> function call instead for each labels?

OK, updated the patch.

[Peng, 2012-03-19 16:10:24]

http://codereview.appspot.com/5845047/diff/1005/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

http://codereview.appspot.com/5845047/diff/1005/ui/gtk3/panel.vala#newcode126
ui/gtk3/panel.vala:126: Gtk.Settings.get_default().get_property("gtk-font-name",
ref value);
I think if the font_name == null, we could just return instead of loading the
default system font.

[fujiwara, 2012-03-20 02:07:52]

On 2012/03/19 16:10:24, Peng wrote:
> http://codereview.appspot.com/5845047/diff/1005/ui/gtk3/panel.vala
> File ui/gtk3/panel.vala (right):
> 
> http://codereview.appspot.com/5845047/diff/1005/ui/gtk3/panel.vala#newcode126
> ui/gtk3/panel.vala:126:
Gtk.Settings.get_default().get_property("gtk-font-name",
> ref value);
> I think if the font_name == null, we could just return instead of loading the
> default system font.

Updated patch.

[Peng, 2012-03-20 03:08:53]

On 2012/03/20 02:07:52, fujiwara wrote:
> On 2012/03/19 16:10:24, Peng wrote:
> > http://codereview.appspot.com/5845047/diff/1005/ui/gtk3/panel.vala
> > File ui/gtk3/panel.vala (right):
> > 
> >
http://codereview.appspot.com/5845047/diff/1005/ui/gtk3/panel.vala#newcode126
> > ui/gtk3/panel.vala:126:
> Gtk.Settings.get_default().get_property("gtk-font-name",
> > ref value);
> > I think if the font_name == null, we could just return instead of loading
the
> > default system font.
> 
> Updated patch.

lgtm. thanks.