Show language id on ibus-ui-gtk3.switcher window.

Show language id on ibus-ui-gtk3.switcher window.


BUG=RH#803177
TEST=Linux desktop

[Peng, 2012-03-18 14:21:09]

https://codereview.appspot.com/5843059/diff/1/ui/gtk3/switcher.vala
File ui/gtk3/switcher.vala (right):

https://codereview.appspot.com/5843059/diff/1/ui/gtk3/switcher.vala#newcode161
ui/gtk3/switcher.vala:161: var id = language;
Maybe you would like to use ibus_get_language_name() to make the language name
more readable?

[fujiwara, 2012-03-19 02:50:45]

On 2012/03/18 14:21:09, Peng wrote:
> https://codereview.appspot.com/5843059/diff/1/ui/gtk3/switcher.vala
> File ui/gtk3/switcher.vala (right):
> 
> https://codereview.appspot.com/5843059/diff/1/ui/gtk3/switcher.vala#newcode161
> ui/gtk3/switcher.vala:161: var id = language;
> Maybe you would like to use ibus_get_language_name() to make the language name
> more readable?

I think the symbol char is more useful than the language name as it could narrow
the window width and express a multi-lingual char.

[Peng, 2012-03-19 04:13:09]

On 2012/03/19 02:50:45, fujiwara wrote:
> On 2012/03/18 14:21:09, Peng wrote:
> > https://codereview.appspot.com/5843059/diff/1/ui/gtk3/switcher.vala
> > File ui/gtk3/switcher.vala (right):
> > 
> >
https://codereview.appspot.com/5843059/diff/1/ui/gtk3/switcher.vala#newcode161
> > ui/gtk3/switcher.vala:161: var id = language;
> > Maybe you would like to use ibus_get_language_name() to make the language
name
> > more readable?
> 
> I think the symbol char is more useful than the language name as it could
narrow
> the window width and express a multi-lingual char.

lgmt

[Peng, 2012-03-21 03:53:13]

On 2012/03/19 04:13:09, Peng wrote:
> On 2012/03/19 02:50:45, fujiwara wrote:
> > On 2012/03/18 14:21:09, Peng wrote:
> > > https://codereview.appspot.com/5843059/diff/1/ui/gtk3/switcher.vala
> > > File ui/gtk3/switcher.vala (right):
> > > 
> > >
> https://codereview.appspot.com/5843059/diff/1/ui/gtk3/switcher.vala#newcode161
> > > ui/gtk3/switcher.vala:161: var id = language;
> > > Maybe you would like to use ibus_get_language_name() to make the language
> name
> > > more readable?
> > 
> > I think the symbol char is more useful than the language name as it could
> narrow
> > the window width and express a multi-lingual char.
> 
> lgmt

I found with CL, the ime switch popup dialog looks very ugly, especially you
enable some IME with very long name. Please try to make it looks better.

[fujiwara, 2012-03-21 05:02:23]

On 2012/03/21 03:53:13, Peng wrote:
> On 2012/03/19 04:13:09, Peng wrote:
> > On 2012/03/19 02:50:45, fujiwara wrote:
> > > On 2012/03/18 14:21:09, Peng wrote:
> > > > https://codereview.appspot.com/5843059/diff/1/ui/gtk3/switcher.vala
> > > > File ui/gtk3/switcher.vala (right):
> > > > 
> > > >
> >
https://codereview.appspot.com/5843059/diff/1/ui/gtk3/switcher.vala#newcode161
> > > > ui/gtk3/switcher.vala:161: var id = language;
> > > > Maybe you would like to use ibus_get_language_name() to make the
language
> > name
> > > > more readable?
> > > 
> > > I think the symbol char is more useful than the language name as it could
> > narrow
> > > the window width and express a multi-lingual char.
> > 
> > lgmt
> 
> I found with CL, the ime switch popup dialog looks very ugly, especially you
> enable some IME with very long name. Please try to make it looks better.

Because the very long name is very ugly.

[Peng, 2012-03-21 12:57:12]

On 2012/03/21 05:02:23, fujiwara wrote:
> On 2012/03/21 03:53:13, Peng wrote:
> > On 2012/03/19 04:13:09, Peng wrote:
> > > On 2012/03/19 02:50:45, fujiwara wrote:
> > > > On 2012/03/18 14:21:09, Peng wrote:
> > > > > https://codereview.appspot.com/5843059/diff/1/ui/gtk3/switcher.vala
> > > > > File ui/gtk3/switcher.vala (right):
> > > > > 
> > > > >
> > >
> https://codereview.appspot.com/5843059/diff/1/ui/gtk3/switcher.vala#newcode161
> > > > > ui/gtk3/switcher.vala:161: var id = language;
> > > > > Maybe you would like to use ibus_get_language_name() to make the
> language
> > > name
> > > > > more readable?
> > > > 
> > > > I think the symbol char is more useful than the language name as it
could
> > > narrow
> > > > the window width and express a multi-lingual char.
> > > 
> > > lgmt
> > 
> > I found with CL, the ime switch popup dialog looks very ugly, especially you
> > enable some IME with very long name. Please try to make it looks better.
> 
> Because the very long name is very ugly.

Not exactly. I think alignment is not correct. All labels are not aligned well.
It is better to adjust it.

[fujiwara, 2012-03-22 10:51:24]

On 2012/03/21 12:57:12, Peng wrote:
> On 2012/03/21 05:02:23, fujiwara wrote:
> > On 2012/03/21 03:53:13, Peng wrote:
> > > On 2012/03/19 04:13:09, Peng wrote:
> > > > On 2012/03/19 02:50:45, fujiwara wrote:
> > > > > On 2012/03/18 14:21:09, Peng wrote:
> > > > > > https://codereview.appspot.com/5843059/diff/1/ui/gtk3/switcher.vala
> > > > > > File ui/gtk3/switcher.vala (right):
> > > > > > 
> > > > > >
> > > >
> >
https://codereview.appspot.com/5843059/diff/1/ui/gtk3/switcher.vala#newcode161
> > > > > > ui/gtk3/switcher.vala:161: var id = language;
> > > > > > Maybe you would like to use ibus_get_language_name() to make the
> > language
> > > > name
> > > > > > more readable?
> > > > > 
> > > > > I think the symbol char is more useful than the language name as it
> could
> > > > narrow
> > > > > the window width and express a multi-lingual char.
> > > > 
> > > > lgmt
> > > 
> > > I found with CL, the ime switch popup dialog looks very ugly, especially
you
> > > enable some IME with very long name. Please try to make it looks better.
> > 
> > Because the very long name is very ugly.
> 
> Not exactly. I think alignment is not correct. All labels are not aligned
well.
> It is better to adjust it.

Probably I think the most easiest fix is to set the left alignment likes:
    "  en English (US)"
    "  あ Anthy"
    "  中 Intelligent Pinyin"
    "  jp Japanese"
    "  中 Pinyin"

If we have the format of "description id", I think a new button or label class
is needed for the left and right alignments to override draw() likes
GtkAccelLabel.