Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 5838043: code review 5838043: make.bat: Fix for old files

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by Topher
Modified:
13 years, 10 months ago
Reviewers:
brainman
CC:
golang-dev, brainman, rsc
Visibility:
Public.

Description

make.bat: Fix for old files Same fix as applied here: http://codereview.appspot.com/5761044 Fixes issue 3222.

Patch Set 1 #

Patch Set 2 : diff -r 131ae87a607b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 131ae87a607b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/make.bat View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Topher
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 10 months ago (2012-03-16 00:13:19 UTC) #1
brainman
Your change looks good to me. But you name is not listed in CONTRIBUTORS file. ...
13 years, 10 months ago (2012-03-16 01:16:54 UTC) #2
Topher
On 2012/03/16 01:16:54, brainman wrote: > Your change looks good to me. But you name ...
13 years, 10 months ago (2012-03-16 02:16:06 UTC) #3
rsc
I've added Christopher to the AUTHORS and CONTRIBUTORS files. Leaving this CL for Alex.
13 years, 10 months ago (2012-03-16 03:15:59 UTC) #4
brainman
LGTM Thank you. Alex
13 years, 10 months ago (2012-03-16 03:30:04 UTC) #5
brainman
13 years, 10 months ago (2012-03-16 03:30:55 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=d77371d5c280 ***

make.bat: Fix for old files

Same fix as applied here: http://codereview.appspot.com/5761044

Fixes issue 3222.

R=golang-dev, alex.brainman, rsc
CC=golang-dev
http://codereview.appspot.com/5838043

Committer: Alex Brainman <alex.brainman@gmail.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b