Issue 583340043: Doc: Added documentation for fill-line line-width

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 9 months ago by davidsg

Modified:
5 years, 9 months ago

Reviewers:
thomasmorley651, lemzwerg, Trevor Daniels, pkx166h-lilypond

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Doc: Added documentation for fill-line line-width Added short descriptions and examples to Notation Reference.

Patch Set 2 : Correction following review #

Patch Set 3 : Correction following review. My apologies, line-width is now without leading backslash. #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	Documentation/notation/text.itely	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download
	M	scm/define-markup-commands.scm	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

davidsg

Doc: Added documentation for fill-line line-width Added short descriptions and examples to Notation Reference. Suggestions ...

5 years, 9 months ago (2020-01-12 17:20:09 UTC) #1

lemzwerg

Only one minor nit :-) Thanks a lot for your contribution! https://codereview.appspot.com/583340043/diff/571320043/Documentation/notation/text.itely File Documentation/notation/text.itely (right): ...

5 years, 9 months ago (2020-01-12 21:13:05 UTC) #3

davidsg

Correction following review. My apologies, line-width is now without leading backslash.

5 years, 9 months ago (2020-01-12 22:19:56 UTC) #5

thomasmorley651

The patch itself LGTM Though sometimes I muse about whether we need NR 1.8.2 Formatting ...

5 years, 9 months ago (2020-01-12 23:27:15 UTC) #6

pkx166h-lilypond

5 years, 9 months ago (2020-01-15 21:51:58 UTC) #7

On 2020/01/12 23:27:15, thomasmorley651 wrote:
> The patch itself LGTM
> 
> Though sometimes I muse about whether we need NR 1.8.2 Formatting text in it's
> current state at all.
> Why do we explain some markup-commands explicitely and others not? They are
all
> listed with examples in
> NR A.11 Text markup commands!
> 
> An alternative would be to improve examples in the markup-commands where
needed
> (as this patch does for fill-line) and, after explaining what markup is and
how
> to use it, simply point to NR A.11.
> We already do similiar for markup-list-commands.

https://sourceforge.net/p/testlilyissues/issues/5664/

Expand All Messages | Collapse All Messages