Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(829)

Issue 583340043: Doc: Added documentation for fill-line line-width

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by davidsg
Modified:
2 months, 3 weeks ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: Added documentation for fill-line line-width Added short descriptions and examples to Notation Reference.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Correction following review #

Patch Set 3 : Correction following review. My apologies, line-width is now without leading backslash. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M Documentation/notation/text.itely View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M scm/define-markup-commands.scm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7
davidsg
Doc: Added documentation for fill-line line-width Added short descriptions and examples to Notation Reference. Suggestions ...
2 months, 3 weeks ago (2020-01-12 17:20:09 UTC) #1
Trevor Daniels
LGTM Trevor
2 months, 3 weeks ago (2020-01-12 19:41:44 UTC) #2
lemzwerg
Only one minor nit :-) Thanks a lot for your contribution! https://codereview.appspot.com/583340043/diff/571320043/Documentation/notation/text.itely File Documentation/notation/text.itely (right): ...
2 months, 3 weeks ago (2020-01-12 21:13:05 UTC) #3
davidsg
Correction following review
2 months, 3 weeks ago (2020-01-12 22:01:45 UTC) #4
davidsg
Correction following review. My apologies, line-width is now without leading backslash.
2 months, 3 weeks ago (2020-01-12 22:19:56 UTC) #5
thomasmorley651
The patch itself LGTM Though sometimes I muse about whether we need NR 1.8.2 Formatting ...
2 months, 3 weeks ago (2020-01-12 23:27:15 UTC) #6
pkx166h-lilypond
2 months, 3 weeks ago (2020-01-15 21:51:58 UTC) #7
On 2020/01/12 23:27:15, thomasmorley651 wrote:
> The patch itself LGTM
> 
> Though sometimes I muse about whether we need NR 1.8.2 Formatting text in it's
> current state at all.
> Why do we explain some markup-commands explicitely and others not? They are
all
> listed with examples in
> NR A.11 Text markup commands!
> 
> An alternative would be to improve examples in the markup-commands where
needed
> (as this patch does for fill-line) and, after explaining what markup is and
how
> to use it, simply point to NR A.11.
> We already do similiar for markup-list-commands.

https://sourceforge.net/p/testlilyissues/issues/5664/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b