Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(527)

Issue 5833050: Make tc_malloc_size(NULL) return 0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by piman
Modified:
12 years, 7 months ago
Reviewers:
chappedm
CC:
google-perftools_googlegroups.com
Base URL:
http://gperftools.googlecode.com/svn/trunk
Visibility:
Public.

Description

Make tc_malloc_size(NULL) return 0 This is consistent with GLIBC's implementation, and some third-party code relies on that behavior. See http://code.google.com/p/chromium/issues/detail?id=118087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/tcmalloc.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
piman
12 years, 8 months ago (2012-03-15 22:29:09 UTC) #1
chappedm
On 2012/03/15 22:29:09, piman wrote: Sorry for the delay. Looks fine to me. I am ...
12 years, 7 months ago (2012-04-21 17:21:33 UTC) #2
chappedm
On 2012/04/21 17:21:33, chappedm wrote: > On 2012/03/15 22:29:09, piman wrote: > > Sorry for ...
12 years, 7 months ago (2012-04-21 17:22:58 UTC) #3
piman
12 years, 7 months ago (2012-04-22 17:37:50 UTC) #4
On Sat, Apr 21, 2012 at 10:22 AM, <chappedm@gmail.com> wrote:

> On 2012/04/21 17:21:33, chappedm wrote:
>
>> On 2012/03/15 22:29:09, piman wrote:
>>
>
>  Sorry for the delay. Looks fine to me. I am committing the patch to
>>
> the main
>
>> trunk.
>>
>
> I don't see any option for marking the review as complete. Do you know
> what the process is? I haven't used this particular review tool before.
>

Thank you for your review!
I marked it as closed (FYI, through the 'Edit issue' link).

Antoine

>
>
https://codereview.appspot.**com/5833050/<https://codereview.appspot.com/5833...
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b