Issue 58320043: Make all chapters' samples more consistent and up to date

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 58320043: Make all chapters' samples more consistent and up to date (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by kathyw

Modified:
11 years, 6 months ago

Reviewers:
misko, misko.hevery, Miško Hevery

CC:
shailentuli

Base URL:
https://github.com/angular/angular.dart.tutorial.git@master

Visibility:
Public.

More Reviews

Description

Make all chapters' samples more consistent and up to date Committed: 3aa0c38

Patch Set 1 #

Patch Set 2 : Ignore generated files #

Patch Set 3 : cmp back to ctrl to fix ch06 breakage #

Patch Set 4 : really fix the "clear filters" bug #

Patch Set 5 : Undo all changes to Chapter 7 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -95 lines)			Patch
M	Chapter_01/README	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Chapter_02/README	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Chapter_03/README	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Chapter_03/lib/rating/rating_component.dart	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download
M	Chapter_03/lib/rating/rating_component.html	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	Chapter_04/README	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Chapter_04/lib/rating/rating_component.dart	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	Chapter_05/README	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Chapter_05/lib/rating/rating_component.dart	View	1	2 chunks	+8 lines, -10 lines	0 comments	Download
M	Chapter_05/lib/rating/rating_component.html	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	Chapter_05/lib/tooltip/tooltip_directive.dart	View	1	1 chunk	+4 lines, -6 lines	0 comments	Download
M	Chapter_06/README	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Chapter_06/lib/component/search_recipe_component.dart	View	1 2 3	1 chunk	+4 lines, -5 lines	0 comments	Download
M	Chapter_06/lib/component/view_recipe_component.dart	View	1 2	1 chunk	+3 lines, -4 lines	0 comments	Download
M	Chapter_06/lib/rating/rating_component.dart	View	1	2 chunks	+8 lines, -10 lines	0 comments	Download
M	Chapter_06/lib/rating/rating_component.html	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	Chapter_06/lib/recipe_book.dart	View	1	3 chunks	+10 lines, -8 lines	0 comments	Download
M	Chapter_06/lib/tooltip/tooltip_directive.dart	View	1	1 chunk	+4 lines, -6 lines	0 comments	Download
M	Chapter_06/web/style.css	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	Chapter_06/web/view/addRecipe.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Chapter_06/web/view/editRecipe.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kathyw

Misko, could you take a look to make sure I'm adhering to good AngularDart practices? ...

11 years, 6 months ago (2014-01-29 19:48:22 UTC) #1

kathyw

11 years, 6 months ago (2014-01-29 21:26:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r3aa0c38 (presubmit successful).

Expand All Messages | Collapse All Messages