Issue 5825051: Address comments from https://codereview.appspot.com/5823050/

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5825051: Address comments from https://codereview.appspot.com/5823050/ (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by thakis

Modified:
12 years, 1 month ago

Reviewers:
Roger Tawa, Roger Tawa (Google)

CC:
rlz-codereviews_googlegroups.com

Base URL:
http://rlz.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Address comments from https://codereview.appspot.com/5823050/ Committed: https://code.google.com/p/rlz/source/detail?r=79

Patch Set 3 : #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -25 lines)			Patch
	M	lib/rlz_lib2.cc	View	1 2	4 chunks	+28 lines, -25 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Roger Tawa (Google)

Thanks Nico. One comment below, what do you think? Or is the lock needed until ...

12 years, 1 month ago (2012-03-14 18:38:20 UTC) #2

thakis

https://codereview.appspot.com/5825051/diff/1/lib/rlz_lib2.cc File lib/rlz_lib2.cc (right): https://codereview.appspot.com/5825051/diff/1/lib/rlz_lib2.cc#newcode281 lib/rlz_lib2.cc:281: return false; On 2012/03/14 18:38:20, rogerta wrote: > I ...

12 years, 1 month ago (2012-03-14 18:42:09 UTC) #3

lgtm

Thanks Nico.

Expand All Messages | Collapse All Messages