Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1398)

Issue 5820068: Make all gyp targets automatically include common.gypi (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by epoger
Modified:
12 years, 6 months ago
Reviewers:
bungeman, bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Make all gyp targets automatically include common.gypi Do this, rather than including common.gypi explicitly in all our gyp files, so that gyp files we use but do not maintain (e.g., third_party/externals/libjpeg/libjpeg.gyp) will include common.gypi too. Committed: https://code.google.com/p/skia/source/detail?r=3411

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -97 lines) Patch
M gyp/FileReaderApp.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/SimpleCocoaApp.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/android_system.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M gyp/animator.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/bench.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/common.gypi View 1 chunk +15 lines, -3 lines 0 comments Download
D gyp/common_variables.gypi View 1 chunk +0 lines, -25 lines 0 comments Download
M gyp/core.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/effects.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/experimental.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/freetype.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/gm.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/gpu.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/images.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/libtess.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/opts.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/pdf.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/ports.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/sfnt.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/svg.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tools.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/utils.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/views.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/xml.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/xps.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp/zlib.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M gyp_skia View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3
epoger
12 years, 6 months ago (2012-03-15 20:40:53 UTC) #1
epoger
If/when I land this change I will ping seanpaul to make sure I'm not breaking ...
12 years, 6 months ago (2012-03-15 20:41:37 UTC) #2
bsalomon
12 years, 6 months ago (2012-03-16 13:17:04 UTC) #3
On 2012/03/15 20:41:37, epoger wrote:
> If/when I land this change I will ping seanpaul to make sure I'm not breaking
> his world with this change. See his http://codereview.appspot.com/5023042
> ('Refactor the bench and common gyp/gypi files to allow for building bench
> within')

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b