Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(873)

Issue 581720054: Do not allow page breaks on the first column of a score (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by hanwenn
Modified:
4 years ago
Reviewers:
thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Do not allow page breaks on the first column of a score This duplicates a column index in the vector of allowed break points, causing a crash. Do some more sanity checking on the input of Constrained_breaking. Fixes #5801

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -11 lines) Patch
A input/regression/page-turn-page-breaking-first-column.ly View 1 chunk +34 lines, -0 lines 0 comments Download
M lily/constrained-breaking.cc View 3 chunks +18 lines, -9 lines 0 comments Download
M lily/include/constrained-breaking.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/page-breaking.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3
thomasmorley651
I've applied your patch and did some testings. It indeed solves the code given with ...
4 years ago (2020-03-01 14:37:19 UTC) #1
hanwenn
On 2020/03/01 14:37:19, thomasmorley651 wrote: > I've applied your patch and did some testings. > ...
4 years ago (2020-03-05 10:24:52 UTC) #2
hanwenn
4 years ago (2020-03-15 15:35:15 UTC) #3
commit ad039e1de14135b9d3bc1bb6d71f729abdc53311
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Fri Feb 28 17:02:38 2020 +0100

    Do not allow page breaks on the first column of a score
    
    This duplicates a column index in the vector of allowed break points,
    causing a crash.
    
    Do some more sanity checking on the input of Constrained_breaking.
    
    Fixes #5801
    
    https://sourceforge.net/p/testlilyissues/issues/5804
    http://codereview.appspot.com/581720054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b