Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9865)

Issue 581560049: Issue 5719: Tie formatting maintenance (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 2 months ago by Dan Eble
Modified:
4 years, 2 months ago
Reviewers:
hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5719/ 1: int->vsize to fix tie-formatting warnings 2: Replace flower's Tuple with std::array 3: ties->front () instead of ties->at (0) ... in contexts where ties->back () is also used. 4: Tie_formatting_problem: [i] instead of at (i) ... in loops where it is clear that the index is in bounds. at () checks the index, which is unnecessary in those places.

Patch Set 1 : int -> vsize #

Patch Set 2 : Tuple -> std::array #

Patch Set 3 : at (0) -> front () #

Patch Set 4 : at (i) -> [i] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -116 lines) Patch
D flower/include/tuple.hh View 1 1 chunk +0 lines, -71 lines 0 comments Download
M lily/include/tie-configuration.hh View 2 chunks +4 lines, -2 lines 0 comments Download
M lily/include/tie-formatting-problem.hh View 1 2 chunks +7 lines, -7 lines 0 comments Download
M lily/tie-configuration.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/tie-formatting-problem.cc View 1 2 3 14 chunks +34 lines, -35 lines 0 comments Download

Messages

Total messages: 4
Dan Eble
Tuple -> std::array
4 years, 2 months ago (2020-01-31 21:25:01 UTC) #1
Dan Eble
at (0) -> front ()
4 years, 2 months ago (2020-01-31 21:25:39 UTC) #2
Dan Eble
at (i) -> [i]
4 years, 2 months ago (2020-01-31 21:26:13 UTC) #3
hahnjo
4 years, 2 months ago (2020-01-31 22:18:16 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b