Issue 5814044: Start moving functions from win/lib/rlz_lib.h to lib/rlz_lib.h

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5814044: Start moving functions from win/lib/rlz_lib.h to lib/rlz_lib.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by thakis

Modified:
14 years, 1 month ago

Reviewers:
Roger Tawa, Roger Tawa (Google)

CC:
rlz-codereviews_googlegroups.com

Base URL:
http://rlz.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Start moving functions from win/lib/rlz_lib.h to lib/rlz_lib.h Start with SetAccessPointRlz() and GetAccessPointRlz(). Add storage functions for these to RlzValueStore. No intended behavior change. Committed: https://code.google.com/p/rlz/source/detail?r=75

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+322 lines, -193 lines)			Patch
M	lib/financial_ping.cc	View		2 chunks	+1 line, -4 lines	0 comments	Download
A	lib/rlz_lib.h	View		1 chunk	+58 lines, -0 lines	0 comments	Download
A	lib/rlz_lib2.cc	View	1 2	1 chunk	+149 lines, -0 lines	0 comments	Download
M	lib/rlz_value_store.h	View		1 chunk	+9 lines, -0 lines	2 comments	Download
M	mac/lib/rlz_value_store_mac.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	mac/lib/rlz_value_store_mac.mm	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	rlz.gyp	View	1 2	1 chunk	+3 lines, -0 lines	2 comments	Download
M	win/lib/rlz_lib.h	View		2 chunks	+2 lines, -34 lines	0 comments	Download
M	win/lib/rlz_lib.cc	View		2 chunks	+0 lines, -148 lines	0 comments	Download
M	win/lib/rlz_value_store_registry.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	win/lib/rlz_value_store_registry.cc	View	1	4 chunks	+67 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thakis

This patch is fairly straightforward. https://codereview.appspot.com/5814044/diff/1/lib/rlz_lib.cc File lib/rlz_lib.cc (right): https://codereview.appspot.com/5814044/diff/1/lib/rlz_lib.cc#newcode18 lib/rlz_lib.cc:18: bool IsAccessPointSupported(rlz_lib::AccessPoint point) { ...

14 years, 1 month ago (2012-03-13 23:14:56 UTC) #1

Roger Tawa (Google)

lgtm https://codereview.appspot.com/5814044/diff/2003/lib/rlz_value_store.h File lib/rlz_value_store.h (right): https://codereview.appspot.com/5814044/diff/2003/lib/rlz_value_store.h#newcode36 lib/rlz_value_store.h:36: char* rlz, // At most kMaxRlzLength + 1 ...

14 years, 1 month ago (2012-03-14 14:04:09 UTC) #2

thakis

14 years, 1 month ago (2012-03-14 16:17:29 UTC) #3

Thanks!

https://codereview.appspot.com/5814044/diff/2003/lib/rlz_value_store.h
File lib/rlz_value_store.h (right):

https://codereview.appspot.com/5814044/diff/2003/lib/rlz_value_store.h#newcode36
lib/rlz_value_store.h:36: char* rlz,  // At most kMaxRlzLength + 1 bytes
On 2012/03/14 14:04:09, rogerta wrote:
> +1 includes the null right?

Yes.

https://codereview.appspot.com/5814044/diff/2003/rlz.gyp
File rlz.gyp (right):

https://codereview.appspot.com/5814044/diff/2003/rlz.gyp#newcode30
rlz.gyp:30: # MSVC can't handle two rlz_lib.cc files in the same library.
On 2012/03/14 14:04:09, rogerta wrote:
> Cool. I guess the intention is the rename this file once the port is done?

Yes. I added a TODO for that.

Expand All Messages | Collapse All Messages